From owner-svn-src-all@freebsd.org  Sun Nov 29 01:43:05 2020
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4D8D947252B;
 Sun, 29 Nov 2020 01:43:05 +0000 (UTC)
 (envelope-from yuripv@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org
 [IPv6:2610:1c1:1:606c::19:3])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "mxrelay.nyi.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4CkB2d1j6Mz3J3F;
 Sun, 29 Nov 2020 01:43:05 +0000 (UTC)
 (envelope-from yuripv@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2DCF810C1;
 Sun, 29 Nov 2020 01:43:05 +0000 (UTC)
 (envelope-from yuripv@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 0AT1h53L012200;
 Sun, 29 Nov 2020 01:43:05 GMT (envelope-from yuripv@FreeBSD.org)
Received: (from yuripv@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id 0AT1h5Ze012199;
 Sun, 29 Nov 2020 01:43:05 GMT (envelope-from yuripv@FreeBSD.org)
Message-Id: <202011290143.0AT1h5Ze012199@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: yuripv set sender to
 yuripv@FreeBSD.org using -f
From: Yuri Pankov <yuripv@FreeBSD.org>
Date: Sun, 29 Nov 2020 01:43:05 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r368140 - head/sys/x86/cpufreq
X-SVN-Group: head
X-SVN-Commit-Author: yuripv
X-SVN-Commit-Paths: head/sys/x86/cpufreq
X-SVN-Commit-Revision: 368140
X-SVN-Commit-Repository: base
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Nov 2020 01:43:05 -0000

Author: yuripv
Date: Sun Nov 29 01:43:04 2020
New Revision: 368140
URL: https://svnweb.freebsd.org/changeset/base/368140

Log:
  hwpstate_intel: don't unconditionally print the error message
  
  Actually check the wrmsr_safe() return value when setting autonomous
  HWP for package.
  
  PR:		245582
  Differential Revision:	https://reviews.freebsd.org/D24744

Modified:
  head/sys/x86/cpufreq/hwpstate_intel.c

Modified: head/sys/x86/cpufreq/hwpstate_intel.c
==============================================================================
--- head/sys/x86/cpufreq/hwpstate_intel.c	Sun Nov 29 01:32:53 2020	(r368139)
+++ head/sys/x86/cpufreq/hwpstate_intel.c	Sun Nov 29 01:43:04 2020	(r368140)
@@ -461,8 +461,10 @@ set_autonomous_hwp(struct hwp_softc *sc)
 		 * not exist." (Intel SDM §14.4.4)
 		 */
 		ret = wrmsr_safe(MSR_IA32_HWP_REQUEST_PKG, sc->req);
-		device_printf(dev,
-		    "Failed to set autonomous HWP for package\n");
+		if (ret) {
+			device_printf(dev,
+			    "Failed to set autonomous HWP for package\n");
+		}
 	}
 
 out: