From owner-cvs-ports@FreeBSD.ORG Wed Jan 4 16:35:13 2012 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 920A01065670; Wed, 4 Jan 2012 16:35:13 +0000 (UTC) (envelope-from sahil@tandon.net) Received: from cricket.hamla.org (cricket.hamla.org [206.251.255.31]) by mx1.freebsd.org (Postfix) with ESMTP id 71ECA8FC14; Wed, 4 Jan 2012 16:35:13 +0000 (UTC) Received: from [10.137.236.92] (mobile-166-137-136-232.mycingular.net [166.137.136.232]) by cricket.hamla.org (Postfix) with ESMTPSA id 2C0628A01D; Wed, 4 Jan 2012 11:35:12 -0500 (EST) References: <201201021534.q02FYLba029039@repoman.freebsd.org> <20120103155438.GA70361@FreeBSD.org> <20120104033137.GB3565@magic.hamla.org> <20120104110248.GA3811@FreeBSD.org> In-Reply-To: <20120104110248.GA3811@FreeBSD.org> Mime-Version: 1.0 (1.0) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Message-Id: X-Mailer: iPhone Mail (9A405) From: Sahil Tandon Date: Wed, 4 Jan 2012 11:35:06 -0500 To: Alexey Dokuchaev X-Virus-Scanned: clamav-milter 0.97.3 at cricket.hamla.org X-Virus-Status: Clean Cc: "cvs-ports@FreeBSD.org" , Yen-Ming Lee , "cvs-all@FreeBSD.org" , "ports-committers@FreeBSD.org" Subject: Re: cvs commit: ports/chinese/tin Makefile ports/chinese/tin/files patch-attrib.c patch-cook.c patch-init.c patch-mail.c patch-tin.defaults patch-tin_defaults X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2012 16:35:13 -0000 On Jan 4, 2012, at 6:02 AM, Alexey Dokuchaev wrote: > On Tue, Jan 03, 2012 at 10:31:37PM -0500, Sahil Tandon wrote: >> On Tue, 2012-01-03 at 15:54:38 +0000, Alexey Dokuchaev wrote: >>> ... >>>> Revision Changes Path >>>> 1.1 +11 -0 ports/chinese/tin/files/patch-tin.defaults (new) >>>> 1.2 +0 -11 ports/chinese/tin/files/patch-tin_defaults (dead)= >>>=20 >>> This renaming of the patch file just because someone thought that dot >>> looks better than underscore is gratuitous and should not have been >>> done. (Not to mention that things that this patch tries to accomplish >>> are usually done with one simple REINPLACE_CMD line.) >>=20 >> I suspect the motivation for the change was to canonicalize the filename >> as described in the PH. >=20 > I understand the motivation; for newly created files, PH rules obviously > should be followed. For already existing patches, esp. when their content= s > stays the same, such blunt renames only cause unnecessary stress on the re= po > and taint the history. Ergo, should be avoided. Sigh, please spare me the same old lecture; your logic is simple and no one i= s questioning that repo churn should be avoided. In your original mail you m= ade reference to someone who thought one character "looking better" than ano= ther was perhaps the motivation for the name change. I pointed out a more li= kely rationale and ultimately agreed that such things are anyway best handle= d in Makefile rather than standalone patches. I also used an emoticon to co= nvey that I was simply guessing the likely motivation for name change and no= t in some way defending it; however, you explicitly removed that and other r= elevant parts of my reply in your quoting above. Over and out, Sahil=