From owner-freebsd-current@FreeBSD.ORG  Tue Nov  9 04:38:22 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 85D3C16A4CE
	for <freebsd-current@freebsd.org>;
	Tue,  9 Nov 2004 04:38:22 +0000 (GMT)
Received: from lakermmtao12.cox.net (lakermmtao12.cox.net [68.230.240.27])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EF66043D1D
	for <freebsd-current@freebsd.org>;
	Tue,  9 Nov 2004 04:38:21 +0000 (GMT)	(envelope-from conrads@cox.net)
Received: from dolphin.local.net ([68.11.30.24]) by lakermmtao12.cox.net
          (InterMail vM.6.01.04.00 201-2131-117-20041022) with ESMTP
          id <20041109043817.LMQN8344.lakermmtao12.cox.net@dolphin.local.net>
          for <freebsd-current@freebsd.org>; Mon, 8 Nov 2004 23:38:17 -0500
Received: from dolphin.local.net (localhost.local.net [127.0.0.1])
	by dolphin.local.net (8.13.1/8.13.1) with SMTP id iA94cKdM047175
	for <freebsd-current@freebsd.org>;
	Mon, 8 Nov 2004 22:38:20 -0600 (CST)	(envelope-from conrads@cox.net)
Date: Mon, 8 Nov 2004 22:38:15 -0600
From: "Conrad J. Sabatier" <conrads@cox.net>
To: freebsd-current@freebsd.org
Message-ID: <20041108223815.517366ea@dolphin.local.net>
X-Mailer: Sylpheed-Claws 0.9.12b (GTK+ 1.2.10; amd64-portbld-freebsd6.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: NO_WERROR: correct usage?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Nov 2004 04:38:22 -0000

The description in /usr/src/UPDATING re: the use of NO_WERROR seems to
be incorrect:

20020815:
        A "bug" in gcc(1) that was hiding warning in system headers was
        fixed.  It's probably time to add -DNO_WERROR to your make line
        again.

Adding "-DNO_WERROR" to CFLAGS in /etc/make.conf seems to have no
effect; the "-Werror" switch still gets added at certain places during
the build.

On the other hand, defining NO_WERROR as a make variable in
/etc/make.conf does seem to work, like so:

NO_WERROR=true

In addition, for kernel builds, it appears that it is necessary to 
define:

WERROR=-Wno-error 

I believe some clarification somewhere (in/usr/src/UPDATING,
/usr/share/examples/etc/make.conf, or /usr/src/Makefile) would be
helpful.

-- 
Conrad J. Sabatier <conrads@cox.net> -- "In Unix veritas"