From owner-freebsd-fs@freebsd.org Tue Apr 3 16:03:29 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3819DF53BD9 for ; Tue, 3 Apr 2018 16:03:29 +0000 (UTC) (envelope-from anthoine.bourgeois@blade-group.com) Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CC14C84703 for ; Tue, 3 Apr 2018 16:03:28 +0000 (UTC) (envelope-from anthoine.bourgeois@blade-group.com) Received: by mail-it0-x244.google.com with SMTP id 15-v6so13249142itl.1 for ; Tue, 03 Apr 2018 09:03:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blade-group-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=6Xr74/MyobwhhFdgXrC8ZFDtTLN2ElEjUEZ2Olfg4NI=; b=E8cpdvd2EZdLf9ikHTx94BeiX95xYkHmeDwuZlW/J2B+O6VNZu2QzND2C9NKE1mShZ zFbXQ3T0kPC42vOs8eUbYDYRn1vN6+/AfGpZtzmKz3HJOw8MH+54Jf3BfBo947YV94Gn IYYEXriu/chXVK7IG9Htp2jI+0V2IckpYuvVHr1eVYT4sDD4svOJFv4KR0VIb251HDsU DCXwJg6cGNnYIMwSuvsv2A0uicOQWjP0M2Q/qAN9GfPi40b6hMxm5aDu8WgLX5jEzlw8 85YbPsFZh8c637XxiPX3KyKKfbVqTjNp/aDi6ztNf5NCQXTAg/rwNDzS/rhP7G1qD8ym UvCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=6Xr74/MyobwhhFdgXrC8ZFDtTLN2ElEjUEZ2Olfg4NI=; b=kc92L5tvAUHALqSX3oi7iCplAWX8lASeq7OTxyvGSuSUU7Y5lPHM1rYyrzkOczpzEg WJRnW0wfJyf/Fn37xZBRHNODfnXUBDjvvie79YtQaA52FwImIVxuG6C3Uw216+d8Dncj hUsZ+CQaqewz92Tze7A3/2GUmvkYykoSx1xWp4stLfMxQvROkSBxn1D4cGAX/nEght1S 6nTCiAKJg0vA29hWiATRfT4q08Vi0a14YKzDGCrWzWFBL3iMGh5xuxZNtqepeYh9GVbq X5gvQKMmW9bflG0S4dmPxqOQVWLmQEjf/amInzPZD8IPRqn6NZpbfBU/P+KpXorU9xew FmMQ== X-Gm-Message-State: ALQs6tBBd5SEfDq9HpOGcYeR4W7fRTkrUi0F6vbwOaOCEIX/3iAhjTYY 8QWPBjNGGP5U0wGE5EHN/rr2ljIu+xJ9KbsOwJRhVQ== X-Google-Smtp-Source: AIpwx48cQsxilRuR99gQB6Q1mMm2QU4jEu8w4uIpafHiQFUaMH9tpARnrgHZyuNY0bEp1eBsHf+XHuBWNmkFC7zSksc= X-Received: by 2002:a24:5b87:: with SMTP id g129-v6mr5911394itb.90.1522771407799; Tue, 03 Apr 2018 09:03:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.2.63.100 with HTTP; Tue, 3 Apr 2018 09:03:27 -0700 (PDT) In-Reply-To: <20180403160149.73nxnm6lgez5n6xk@gmail.com> References: <20180403160149.73nxnm6lgez5n6xk@gmail.com> From: Anthoine Bourgeois Date: Tue, 3 Apr 2018 18:03:27 +0200 Message-ID: Subject: ZFS: move zvol device operation out of txg sync thread To: freebsd-fs@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 16:03:29 -0000 Hello, I posted the review https://reviews.freebsd.org/D14669 I wonder if I should insert the command in the queue earlier in the functions or should it be fine to be close to the dsl_dataset operations as it is currently ? Any review is welcome. Another question: I create a new review D14669 because I can't find how to update the review D7179, that may be more proper I think. When I click on "Update diff" and select my diff file, the "Attach To" list only show me the "Create a new revision..." option. Is is normal ? Best, Anthoine