From owner-freebsd-hackers Thu May 18 23:29:34 1995 Return-Path: hackers-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id XAA13644 for hackers-outgoing; Thu, 18 May 1995 23:29:34 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id XAA13638 for ; Thu, 18 May 1995 23:29:28 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id XAA15894; Thu, 18 May 1995 23:22:32 -0700 From: "Rodney W. Grimes" Message-Id: <199505190622.XAA15894@gndrsh.aac.dev.com> Subject: Re: Fix for 3C509 (ep) driver To: babkin@hq.icb.chel.su (Serge A. Babkin) Date: Thu, 18 May 1995 23:22:32 -0700 (PDT) Cc: davidg@Root.COM, hackers@FreeBSD.org, steve@simon.chi.il.us, martin@victor.innovus.com In-Reply-To: <199505182051.BAA07069@hq.icb.chel.su> from "Serge A. Babkin" at May 19, 95 01:51:58 am X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 1576 Sender: hackers-owner@FreeBSD.org Precedence: bulk > > Review please this patch (and commit it if you think it's OK). > It does: > > 1. Card is normally initialized after warm reboot from DOS. This > part of patch is written by Steven E. Piette > > Now it has no kdc_...(I forgot what exactly)... hook that is called > on system halt because I'm still running 950210-SNAP what doesn't > have this hook. > > 2. Card works OK with "plug-n-play" mode enabled too (ISA cards only). > I'm not shure about EISA autoconfiguration procedure so I didn't > changed it. > > Perhaps the same changes should be done with Netboot, but I don't have > its recent version. > > The patch is: I don't have any problem with this patch, but would like to ask that you try to find at least 3 other sites running on the if_ep code and ask them to test this out to make sure we do not break any of the other boards suported by this driver. Also for future reference *please* do not patch the $Id$ strings, I sure as heck down show a version 1.14 checked into cvs by root, as root is not allowed to check files in on Freefall. I now don't have an easy way to verify what FreeBSD version of this file the patch is against :-( :-( :-(. Also patching the Rcs $Id$ may do strange things to cvs diff down the road, I am not quite just what value ends up stored in the rcs file when you do this (I need to go look, I have seen problems here before). -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD