Date: Thu, 10 Jan 2013 18:51:35 +0000 (UTC) From: Warner Losh <imp@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r245263 - head/sys/dev/sym Message-ID: <201301101851.r0AIpZZN095568@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: imp Date: Thu Jan 10 18:51:35 2013 New Revision: 245263 URL: http://svnweb.freebsd.org/changeset/base/245263 Log: Clang complains about the comparision of fak < 0 always being false. It is right. Delete it because on the next line we catch all 'negative' cases with the test > 2, since 'negative' numbers are just really big unsigned numbers and we do an identical action. Modified: head/sys/dev/sym/sym_hipd.c Modified: head/sys/dev/sym/sym_hipd.c ============================================================================== --- head/sys/dev/sym/sym_hipd.c Thu Jan 10 18:24:48 2013 (r245262) +++ head/sys/dev/sym/sym_hipd.c Thu Jan 10 18:51:35 2013 (r245263) @@ -3426,7 +3426,6 @@ sym_getsync(hcb_p np, u_char dt, u_char /* * Check against our hardware limits, or bugs :). */ - if (fak < 0) {fak = 0; ret = -1;} if (fak > 2) {fak = 2; ret = -1;} /*
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201301101851.r0AIpZZN095568>