Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 04 Apr 2002 21:52:30 -0700
From:      "Justin T. Gibbs" <gibbs@scsiguy.com>
To:        mjacob@feral.com
Cc:        Terry Lambert <tlambert2@mindspring.com>, Andrew Gallatin <gallatin@cs.duke.edu>, freebsd-current@freebsd.org
Subject:   Re: BUS_SPACE_MAXSIZE & isp driver. 
Message-ID:  <200204050452.g354qV972436@aslan.scsiguy.com>
In-Reply-To: Your message of "Thu, 04 Apr 2002 19:25:49 PST." <Pine.BSF.4.21.0204041922470.78599-100000@beppo> 

next in thread | previous in thread | raw e-mail | index | archive | help
>> a single buffer.  I never realized that there was such controversy
>> over this value... it was just put in so that I could have something
>> for the non-GNUC case.
>
>Yeah, but, uh, it'll blow up in one's face.....

If it gets compiled, I suppose so.

>The question I have is what *should* we be using? Should BUS_SPACE_MAXSIZE be
>bumped up so that any dma allocation we attempt for a platform will fit within
>it?

I think it should go away.  We should malloc space to hold the segments in
the leaf dma tags and base that size on the information in the tag.  The
segments would only be allocated on the first dma_map_create call on a
tag so that intermediate (i.e. non-leaf) tags never have this stuff allocated.

>I mean, it's used in a lot of places, so clearly it must mean something,
>right? What are the semantics here?

Is it really used in a lot of places?  I've always used the "bit sized"
versions of MAXSIZE in my driver code, never the ambiguous one. 8-)

--
Justin

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200204050452.g354qV972436>