From owner-freebsd-current  Fri Mar 30 15:51:37 2001
Delivered-To: freebsd-current@freebsd.org
Received: from bunrab.catwhisker.org (adsl-63-193-123-122.dsl.snfc21.pacbell.net [63.193.123.122])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0EF5637B719; Fri, 30 Mar 2001 15:51:31 -0800 (PST)
	(envelope-from david@catwhisker.org)
Received: (from david@localhost)
	by bunrab.catwhisker.org (8.10.0/8.10.0) id f2UNpRo26499;
	Fri, 30 Mar 2001 15:51:27 -0800 (PST)
Date: Fri, 30 Mar 2001 15:51:27 -0800 (PST)
From: David Wolfskill <david@catwhisker.org>
Message-Id: <200103302351.f2UNpRo26499@bunrab.catwhisker.org>
To: audit@FreeBSD.ORG, current@FreeBSD.ORG, phk@FreeBSD.ORG
Subject: Re: Call for review... PR 25577
In-Reply-To: <22391.985986428@critter>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

>From: Poul-Henning Kamp <phk@FreeBSD.ORG>
>Date: Fri, 30 Mar 2001 23:07:08 +0200

>Any comments/reviews before we commit the patch to PR25577 ?

OK; I've built today's -CURRENT (this time, after applying Brooks'
patchset; I had built -CURRENT earlier today).

Here's a (slightly sanitized) ifconfig output:

m758712358[1] ifconfig
gif0: flags=8010<POINTOPOINT,MULTICAST> mtu 1280
gif1: flags=8010<POINTOPOINT,MULTICAST> mtu 1280
gif2: flags=8010<POINTOPOINT,MULTICAST> mtu 1280
gif3: flags=8010<POINTOPOINT,MULTICAST> mtu 1280
lo0: flags=8049<UP,LOOPBACK,RUNNING,MULTICAST> mtu 16384
        inet6 fe80::1%lo0 prefixlen 64 scopeid 0x5 
        inet6 ::1 prefixlen 128 
        inet 127.0.0.1 netmask 0xff000000 
ppp0: flags=8010<POINTOPOINT,MULTICAST> mtu 1500
faith0: flags=8000<MULTICAST> mtu 1500
an0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 1500
        inet6 fe80::240:96ff:fe34:4ee9%an0 prefixlen 64 scopeid 0x8 
        inet 207.76.207.214 netmask 0xffffff00 broadcast 207.76.207.255
        ether 00:40:96:34:4e:e9 
        media: autoselect (DS/11Mbps) status: associated
        supported media: autoselect autoselect <adhoc> DS/11Mbps DS/11Mbps <adhoc> DS/5.5Mbps DS/5.5Mbps <adhoc> DS/2Mbps DS/2Mbps <adhoc> DS/1Mbps DS/1Mbps <adhoc>
        ssid <SSID goes here>
        stationname ""
        channel 6 authmode OPEN powersavemode OFF powersavesleep 200
        wepmode OFF weptxkey 2
        wepkey 1:64-bit
m758712358[2] 


So I haven't got so far as to actually *use* the ifconfig capabilities to
get the card configured -- I had already worked up a script to do that
with ancontrol, and I wanted to get this out sooner than it would take me
to re-work that.

First, this looks very promising; I like the direction and the bulk of
the implementation (from what I've seen so far).

One concern, and this may well affect other NIC flavors, is the list of
media types is a little annoying to parse.  Hmmm... speaking Perl, I
suppose it could be characterized as

	/^\s+supported media:(\s[\S+(\s<adhoc>)?)+$/

Nevertheless, I believe it would be a little easier to parse (both for
people & simple scripts) if the separator before "<adhoc>" were
different from the one between adjacent supported media.

Or am I just being rather denser than usual?

Thanks,
david
-- 
David H. Wolfskill				david@catwhisker.org
As a computing professional, I believe it would be unethical for me to
advise, recommend, or support the use (save possibly for personal
amusement) of any product that is or depends on any Microsoft product.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message