Date: Fri, 21 Nov 2014 11:51:08 +0100 From: Fabian Keil <freebsd-listen@fabiankeil.de> To: freebsd-ports@freebsd.org Cc: freebsd-ports@freebsd.org Subject: Re: Request for (i386) testing: american fuzzy lop Message-ID: <1557502e.1751489a@fabiankeil.de> In-Reply-To: <a93l-6cj5-wny@vfemail.net> References: <3dc1c153.7b7b9177@fabiankeil.de> <546DF8A5.3060601@gmail.com> <3fb914c3.1002708a@fabiankeil.de> <a93l-6cj5-wny@vfemail.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/KvgEBbXwaW2s20ls+21=PSW
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Jan Beich <jbeich@vfemail.net> wrote:
> Fabian Keil <freebsd-listen@fabiankeil.de> writes:
>=20
> > Vitaly Magerya <vmagerya@gmail.com> wrote:
> >> I don't know what this part is supposed to do:
> >>=20
> >> # Workaround to make sure clang isn't confused for gcc
> >> CC=3D${COMPILER_TYPE}
> >>=20
> >> ... but it seems to set CC to empty string on my machine; and I
> >> get a whole bunch of this as the result:
> >
> > Interesting.
> >
> > It was supposed to set CC for gmake to either clang or gcc,
> > otherwise a cc that is clang is treated as gcc.
> >
> > However clobbering CC directly is obviously wrong and on
> > systems where cc is still gcc, the workaround shouldn't
> > be necessary anyway.
> >
> > Does it work for you if you replace the line with:
> > MAKE_ARGS+=3D CC=3D${COMPILER_TYPE}
> > ?
>=20
> USE_GCC becomes a nop while setting explicitly fails
>=20
> $ uname -rp
> 11.0-CURRENT amd64
>=20
> $ echo CC=3Dgcc49 >>/etc/.make.conf
> $ make
> ...
> =3D=3D=3D> Building for afl-0.60b
> gmake[2]: Entering directory '/work/afl-0.60b'
> [*] Checking for the ability to compile x86 code...
> [+] All done! Be sure to review README - it's pretty short and useful.
> gcc: not found
>=20
> Why not patch the vendor Makefile? Here're my changes:
>=20
> - use $(CC) --version to detect clang
> - remove -g from CFLAGS (see WITH_DEBUG)
> - strip(1) binaries during install
> - global TESTing with generic option name
Thanks a lot for the patch.
The CC detection has already been fixed upstream, but I took the
rest of the changes with the exception of renaming TEST_INSTRUMENTATION
to TEST (I think it's overloaded already, just like DOCS).
=20
> while poudriere caught Clang i386 failing
>=20
> [*] Testing the CC wrapper and instrumentation output...
> AFL_QUIET=3D1 AFL_INST_RATIO=3D100 AFL_PATH=3D. ./afl-clang -O2 -pipe =
-fstack-protector -fno-strict-aliasing -Wall -D_FORTIFY_SOURCE=3D2 -Wno-poi=
nter-sign -DAFL_PATH=3D\"/prefix/afl-0.60b/lib/afl\" -DDOC_PATH=3D\"/prefix=
/afl-0.60b/share/doc/afl\" -DVERSION=3D\"0.60b\" -Wno-format test-instr.c -=
o test-instr
> /tmp/.afl-19244-1416499444.s: Assembler messages:
> /tmp/.afl-19244-1416499444.s:222: Error: unknown pseudo-op: `.cfi_secti=
ons'
> clang: error: assembler command failed with exit code 1 (use -v to see =
invocation)
I updated the port to (hopefully) use as from ports on i386:
http://www.fabiankeil.de/sourcecode/freebsd/afl-61b.shar
Does this make a difference?
If not, I'll probably just submit the port marked as broken
for i386 and try to get this working later on.
Fabian
--Sig_/KvgEBbXwaW2s20ls+21=PSW
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iEYEARECAAYFAlRvGRwACgkQBYqIVf93VJ2BrwCeL3x/7jjGhT8PaVflPu0Kl602
IzsAoK1EzSdRMHY3UYCNWYzLXtK60v9R
=Y9qp
-----END PGP SIGNATURE-----
--Sig_/KvgEBbXwaW2s20ls+21=PSW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1557502e.1751489a>