From owner-freebsd-ports@freebsd.org Sun Aug 21 19:35:08 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E0981BC0CD7 for ; Sun, 21 Aug 2016 19:35:08 +0000 (UTC) (envelope-from kwm@FreeBSD.org) Received: from smtpq6.tb.mail.iss.as9143.net (smtpq6.tb.mail.iss.as9143.net [212.54.42.169]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A05F41365; Sun, 21 Aug 2016 19:35:08 +0000 (UTC) (envelope-from kwm@FreeBSD.org) Received: from [212.54.42.116] (helo=lsmtp2.tb.mail.iss.as9143.net) by smtpq6.tb.mail.iss.as9143.net with esmtp (Exim 4.82) (envelope-from ) id 1bbYEL-0002h0-AI; Sun, 21 Aug 2016 21:16:25 +0200 Received: from 178-84-134-112.dynamic.upc.nl ([178.84.134.112] helo=[192.168.0.51]) by lsmtp2.tb.mail.iss.as9143.net with esmtp (Exim 4.82) (envelope-from ) id 1bbYEL-0004vm-7K; Sun, 21 Aug 2016 21:16:25 +0200 Message-ID: <1471806984.2646.4.camel@FreeBSD.org> Subject: Re: iso-codes From: Koop Mast To: koobs@FreeBSD.org, Lena@lena.kiev.ua Cc: freebsd-ports@freebsd.org Date: Sun, 21 Aug 2016 21:16:24 +0200 In-Reply-To: <08f0f320-f4c3-233c-d43a-015a31bc879e@FreeBSD.org> References: <20160821104951.GL916@lena.kiev> <08f0f320-f4c3-233c-d43a-015a31bc879e@FreeBSD.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Ziggo-spambar: / X-Ziggo-spamscore: 0.0 X-Ziggo-spamreport: CMAE Analysis: v=2.1 cv=Dt6rgzL+ c=1 sm=0 tr=0 a=IkcTkHD0fZMA:10 a=7z1cN_iqozsA:10 a=6I5d2MoRAAAA:8 a=tS1qzdGnnUQ1SefVEaEA:9 a=QEXdDO2ut3YA:10 a=IjZwj45LgO3ly-622nXo:22 xcat=Undefined/Undefined none X-Ziggo-Spam-Status: No X-Spam-Status: No X-Spam-Flag: No X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Aug 2016 19:35:09 -0000 On Mon, 2016-08-22 at 02:42 +1000, Kubilay Kocak wrote: > On 21/08/2016 8:49 PM, Lena@lena.kiev.ua wrote: > > > > Does the latest version of the port misc/iso-codes really need > > python 3 > > for build? > > > > Python 2.7 not enough? > > > > https://svnweb.freebsd.org/ports/head/misc/iso-codes/Makefile?r1=40 > > 9133&r2=420522 > A grep of the sources shows many references to python3 (calling > script), > including: I think Lena is more wondering about the new build requirement off python3. As your pointed out the scripts require python3, there is not much I can do about that. I also don't see much point in trying to bash the scripts into shape using the full version (3.4 in this case) python version since they are only used during build time. -Koop > bin/validate_json_data.py:#!/usr/bin/env python3 > bin/xml_from_json.py:#!/usr/bin/env python3 > bin/pot_from_json.py:#!/usr/bin/env python3 > bin/check_valid_utf8.py:#!/usr/bin/env python3 > > And in the build system: > > common.mk:      python3 $(top_srcdir)/bin/pot_from_json.py $(DOMAIN) > $(top_srcdir)/data > common.mk:      python3 $(top_srcdir)/bin/xml_from_json.py $(DOMAIN) > $(top_srcdir)/data $@ > common.mk:      python3 $(top_srcdir)/bin/check_valid_utf8.py > $(pofiles) > > I didn't check whether this was a recent change (new in 3.69) or not. > > These could/should be updated to use python3.x scripts directly > instead, > rather then the python3 symlink provided by lang/python3. This could > be > done with judicious use of USES=shebangfix > > Maintainer CC'd > > Hope that helps Lena > > ./koobs