From owner-svn-src-head@FreeBSD.ORG Thu Jul 18 01:18:07 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 8F6F7CC1 for ; Thu, 18 Jul 2013 01:18:07 +0000 (UTC) (envelope-from scott4long@yahoo.com) Received: from nm5-vm1.bullet.mail.ne1.yahoo.com (nm5-vm1.bullet.mail.ne1.yahoo.com [98.138.91.32]) by mx1.freebsd.org (Postfix) with ESMTP id 4431A977 for ; Thu, 18 Jul 2013 01:18:07 +0000 (UTC) Received: from [98.138.90.51] by nm5.bullet.mail.ne1.yahoo.com with NNFMP; 18 Jul 2013 01:18:00 -0000 Received: from [98.138.104.112] by tm4.bullet.mail.ne1.yahoo.com with NNFMP; 18 Jul 2013 01:18:00 -0000 Received: from [127.0.0.1] by smtp221.mail.ne1.yahoo.com with NNFMP; 18 Jul 2013 01:18:00 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1374110280; bh=jXLtKc+niuZg5sm5fjHrSF5gTI9WBceOjkATdVf9pm8=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:Content-Transfer-Encoding:Message-Id:References:To:X-Mailer; b=MYEjYsubtTN6yv2D7QgS9uHKB023LvebeVeLJmOrCFYS/AihI+FpUqsjX5jnQrviTgkwDqjZsEdHCXAuTMYwmZBKYd4cv3LEvdEt3n9nFAt/+QHK99X5dZteJTiNdnbWB2yA/v/Aq8kNgBeE8+USmLJi1IBb1QpIUjiBac0wkgw= X-Yahoo-Newman-Id: 591134.34953.bm@smtp221.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: YlTyKz0VM1ksLvQ2ZOErOkpgTPzPT0j7sHoFY9Op0kHJxxn hvW1.knmCj9EAe2L6Vss5b9BVv0DB1rGWhoHn.9_McAl6ZMhMLbNLj5_wrk3 A3OrdRe9zMh0BgxinTRwTEriZDQInoMlqTCT7P3HMNcXbaCAX.v0PYLE6nbx 3k.1C2LV0gG8rCCW0RBNBprXC8RMvSnZuqY5AAYsKZHYidpaUynSS6sION7u qPse0tSE1RlX.LtoEP88LyLPCLUfLsc.tGcj0jVtYQ.9ioizaiYip.ON_asY BV18jdtXBDnq9IB_5c1c4Dek08ZgRyGRhfjuPQqBr2eyyZtDGLzj8.qhRrL. c.4QTiwPzPHW2xWfFCOJobcWltoSVgXROZ5jaGw_7LIfK0WgPhX7IolJu_yW PAGGlOCw8l9AeRlmKAaVOg3Q50AEnG0NOMQPvu5ehdTOmoB3.pAnxpUtKmJW 3Ake9WSEUCt9mXftv8icqT39qMIEX2vcohtlxdWddy1NtX3M1gi5S5L43amQ Y_pziK4_nAMSDuNnD7H5..edzLQ0Irg-- X-Yahoo-SMTP: clhABp.swBB7fs.LwIJpv3jkWgo2NU8- X-Rocket-Received: from lgmac-dkrishnan.corp.netflix.com (scott4long@69.53.237.126 with ) by smtp221.mail.ne1.yahoo.com with SMTP; 18 Jul 2013 01:18:00 +0000 UTC Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: svn commit: r253427 - head/sbin/route From: Scott Long In-Reply-To: <20130718010038.GD2264@glenbarber.us> Date: Wed, 17 Jul 2013 19:17:58 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <2AE597F6-02A5-405F-B1D8-34054A0DA1C4@yahoo.com> References: <201307171405.r6HE5KpR005269@svn.freebsd.org> <20130718010038.GD2264@glenbarber.us> To: Glen Barber X-Mailer: Apple Mail (2.1508) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Hiroki Sato , src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jul 2013 01:18:07 -0000 On Jul 17, 2013, at 7:00 PM, Glen Barber wrote: > On Wed, Jul 17, 2013 at 02:05:20PM +0000, Hiroki Sato wrote: >> Author: hrs >> Date: Wed Jul 17 14:05:20 2013 >> New Revision: 253427 >> URL: http://svnweb.freebsd.org/changeset/base/253427 >>=20 >> Log: >> - Add support of MK_INET_SUPPORT=3Dno. >> - Fix a bug in sodump() which prevented struct sockaddr_in6 from = displaying. >> - Fix a bug in in fiboptlist_csv() which could cause free() of = uninitialized >> pointer. >> - Style cleanups: >> . Add missing "static" keywords. >> . Use an array of struct sockaddr_storage instead of sockunion for = rtmsg. >> . Use err() and errx() instead of pair of fprintf(stderr, "...") + = exit(1). >> . Use nitems() macro. >> . Various style(9) fixes. >>=20 >> Modified: >> head/sbin/route/Makefile >> head/sbin/route/route.c >>=20 >=20 > [...] >=20 >> Modified: head/sbin/route/route.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sbin/route/route.c Wed Jul 17 14:04:18 2013 = (r253426) >> +++ head/sbin/route/route.c Wed Jul 17 14:05:20 2013 = (r253427) > [...] >> @@ -1470,14 +1498,12 @@ rtmsg(int cmd, int flags, int fib) >> rtm.rtm_rmx =3D rt_metrics; >> rtm.rtm_inits =3D rtm_inits; >>=20 >> - if (rtm_addrs & RTA_NETMASK) >> - mask_addr(); >> - NEXTADDR(RTA_DST, so_dst); >> - NEXTADDR(RTA_GATEWAY, so_gate); >> - NEXTADDR(RTA_NETMASK, so_mask); >> - NEXTADDR(RTA_GENMASK, so_genmask); >> - NEXTADDR(RTA_IFP, so_ifp); >> - NEXTADDR(RTA_IFA, so_ifa); >> + NEXTADDR(RTA_DST, so[RTAX_DST]); >> + NEXTADDR(RTA_GATEWAY, so[RTAX_GATEWAY]); >> + NEXTADDR(RTA_NETMASK, so[RTAX_NETMASK]); >> + NEXTADDR(RTA_GENMASK, so[RTAX_GENMASK]); >> + NEXTADDR(RTA_IFP, so[RTAX_IFP]); >> + NEXTADDR(RTA_IFA, so[RTAX_IFA]); >> rtm.rtm_msglen =3D l =3D cp - (char *)&m_rtmsg; >> if (verbose) >> print_rtmsg(&rtm, l); >=20 > I think this breaks head/, at least for ia64. >=20 Yes, as well as for amd64. This breakage occurred at the exact moment = that we tried to cut over to HEAD at Netflix. It's indeed a Brave New = World. Should we back it out? Scott