From owner-svn-src-head@freebsd.org Mon Apr 20 18:37:49 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 017B12AAB8A; Mon, 20 Apr 2020 18:37:49 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (mail.daemonic.se [IPv6:2607:f740:d:20::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 495b6N66jSz3LKj; Mon, 20 Apr 2020 18:37:48 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 495b6D72Cvz3mD0; Mon, 20 Apr 2020 18:37:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([IPv6:::1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [IPv6:::1]) (amavisd-new, port 10587) with ESMTPS id CEaArZz5Ek5h; Mon, 20 Apr 2020 18:35:20 +0000 (UTC) Received: from garnet.daemonic.se (unknown [IPv6:2001:470:dca9:201:39ae:b103:6efc:d521]) by mail.daemonic.se (Postfix) with ESMTPSA id 495Zpy2fQMz3mD1; Mon, 20 Apr 2020 18:24:26 +0000 (UTC) Subject: Re: svn commit: r360126 - head/sys/dev/evdev To: cem@freebsd.org Cc: src-committers , svn-src-all , svn-src-head References: <202004201617.03KGHHj7074077@repo.freebsd.org> <20200420113957.50d41308@titan.knownspace> From: Niclas Zeising Message-ID: <1a901390-992f-7f5b-899a-660365da174d@freebsd.org> Date: Mon, 20 Apr 2020 20:24:25 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 495b6N66jSz3LKj X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2020 18:37:49 -0000 On 2020-04-20 20:13, Conrad Meyer wrote: > Hi Niclas, > > On Mon, Apr 20, 2020 at 9:57 AM Niclas Zeising wrote: >> >> On 2020-04-20 18:39, Justin Hibbits wrote: >>> For just powerpc32, >>> you should have: >>> >>> #if defined(__powerpc__) && !defined(__powerpc64__) >> >> Ok, I wasn't aware of that, I'll fix it. > > FYI, arch(7) is a great resource here (thanks, emaste@): > > """ > Architecture-specific macros: > > Architecture Predefined macros > ... > powerpc __powerpc__ > powerpcspe __powerpc__, __SPE__ > powerpc64 __powerpc__, __powerpc64__ > """ > > For other predefined macros not covered in arch(7), I highly recommend > https://sourceforge.net/p/predef/wiki/Home/ . > I'll remember that for next time, thanks! In any case, this should be fixed with r360132, sorry about that. Regards -- Niclas Zeising