From owner-freebsd-bugs  Sun Aug  8 17:19:30 1999
Delivered-To: freebsd-bugs@freebsd.org
Received: from rover.village.org (rover.village.org [204.144.255.49])
	by hub.freebsd.org (Postfix) with ESMTP
	id D6DBD14DEC; Sun,  8 Aug 1999 17:19:15 -0700 (PDT)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (harmony.village.org [10.0.0.6])
	by rover.village.org (8.9.3/8.9.3) with ESMTP id SAA11050;
	Sun, 8 Aug 1999 18:17:26 -0600 (MDT)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id SAA02508; Sun, 8 Aug 1999 18:17:18 -0600 (MDT)
Message-Id: <199908090017.SAA02508@harmony.village.org>
To: mobile@FreeBSD.ORG
Subject: Re: [APM] kernel panic with apm command(Sotec WinBookPro). 
Cc: freebsd-bugs@FreeBSD.ORG, sanpei@sanpei.org,
	iwasaki@jp.freebsd.org
In-reply-to: Your message of "Mon, 09 Aug 1999 01:46:12 +0900."
		<199908081642.BAA01817@tasogare.imasy.or.jp> 
References: <199908081642.BAA01817@tasogare.imasy.or.jp>  <199908081506.AAA18497@lavender.yy.cs.keio.ac.jp> 
Date: Sun, 08 Aug 1999 18:17:18 -0600
From: Warner Losh <imp@village.org>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

In message <199908081642.BAA01817@tasogare.imasy.or.jp> Mitsuru IWASAKI writes:
: Anyone review my patch for this?

I've been running your patch for a while now.  I don't have an old APM
BIOS that causes problems...

The patch looks good to me, except this part

: +		if ((ret = apm_bioscall())) {
: +			if (ret == -1) {
: +				error = ENOSYS;

which should return be EINVAL.  ENOSYS is returned only when the
system call itself isn't implemented.  Since ioctl is implemented on
FreeBSD, returning it would be inappropriate.

Warner


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message