From owner-freebsd-bugs@freebsd.org Sun Oct 20 15:21:51 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5F197161A96 for ; Sun, 20 Oct 2019 15:21:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46x3Ql1ybpz3LJR for ; Sun, 20 Oct 2019 15:21:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 434BA161A95; Sun, 20 Oct 2019 15:21:51 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 430AD161A93 for ; Sun, 20 Oct 2019 15:21:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46x3Ql13Pnz3LJQ for ; Sun, 20 Oct 2019 15:21:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0905ADB71 for ; Sun, 20 Oct 2019 15:21:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x9KFLoHg032269 for ; Sun, 20 Oct 2019 15:21:50 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x9KFLoMt032204 for bugs@FreeBSD.org; Sun, 20 Oct 2019 15:21:50 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 241373] [UFS] Rename should update the ctime of a multiply-linked destination Date: Sun, 20 Oct 2019 15:21:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: asomers@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.mimetype attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Oct 2019 15:21:51 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D241373 Bug ID: 241373 Summary: [UFS] Rename should update the ctime of a multiply-linked destination Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: asomers@FreeBSD.org Attachment #208465 text/plain mime type: Created attachment 208465 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D208465&action= =3Dedit Regression test ctime should be updated whenever a file's link count changes. If its destination is multiply-linked, rename(2) will decrease its link count, and therefore should update its ctime. ZFS complies, but as of r353698 UFS does not. I have two test cases demonstrating the problem: a standalone C progr= am (attached), and a pjdfstest test case (https://github.com/pjd/pjdfstest/pull/37). Standalone test's output on UFS: $ /tmp/rename_ctime_link nlink: 2 -> 1 ctime 1571584801.941284000 -> 1571584801.941284000 Renamed failed to update destination's ctime. And on ZFS: $ /tmp/rename_ctime_link=20 nlink: 2 -> 1 ctime 1571584883.332680000 -> 1571584884.384654000 Everything ok! $ uname -a FreeBSD fbsd-head.lauralan.noip.me 13.0-CURRENT FreeBSD 13.0-CURRENT #50 r353698: Thu Oct 17 15:17:38 MDT 2019=20=20=20=20 somers@fbsd-head.lauralan.noip.me:/usr/obj/usr/home/somers/freebsd/base/hea= d/amd64.amd64/sys/GENERIC amd64 $ mount /dev/vtbd0p2 on / (ufs, local, journaled soft-updates) devfs on /dev (devfs) 192.168.0.2:/home on /usr/home (nfs, nfsv4acls) tank on /tank (zfs, local, nfsv4acls) --=20 You are receiving this mail because: You are the assignee for the bug.=