From owner-freebsd-bugs@FreeBSD.ORG Sun Sep 12 23:40:15 2004 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 41B7216A4CE; Sun, 12 Sep 2004 23:40:15 +0000 (GMT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1CFF643D1D; Sun, 12 Sep 2004 23:40:15 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id i8CNejZk010409; Sun, 12 Sep 2004 16:40:45 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id i8CNejfE010408; Sun, 12 Sep 2004 16:40:45 -0700 Date: Sun, 12 Sep 2004 16:40:45 -0700 From: Brooks Davis To: Giorgos Keramidas Message-ID: <20040912234044.GA9417@odin.ac.hmc.edu> References: <200409122010.i8CKAtIb028207@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BXVAT5kNtrzKuDFl" Content-Disposition: inline In-Reply-To: <200409122010.i8CKAtIb028207@freefall.freebsd.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu cc: freebsd-bugs@freebsd.org Subject: Re: bin/71616: [PATCH] cleanup of the usr.sbin/yp_mkdb code X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2004 23:40:15 -0000 --BXVAT5kNtrzKuDFl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 12, 2004 at 08:10:55PM +0000, Giorgos Keramidas wrote: > The following reply was made to PR bin/71616; it has been noted by GNATS. >=20 > From: Giorgos Keramidas > To: Dan Lukes > Cc: bug-followup@freebsd.org > Subject: Re: bin/71616: [PATCH] cleanup of the usr.sbin/yp_mkdb code > Date: Sun, 12 Sep 2004 21:23:45 +0300 >=20 > On 2004-09-12 04:37, Dan Lukes wrote: > > *** usr.sbin/yp_mkdb/yp_mkdb.c.ORIG Sun Sep 5 18:54:07 2004 > > --- usr.sbin/yp_mkdb/yp_mkdb.c Sun Sep 5 19:01:20 2004 > > [...] > > - snprintf(buf, sizeof(buf), "%lu", time(NULL)); > > + snprintf(buf, sizeof(buf), "%lu", (long unsigned int)time(NULL)); > =20 > Just a minor comment: An (unsigned long) cast should be fine here. > =20 > There's no need to add `int' and the ordering of long unsigned seems a b= it > backwards -- most of the time I've seen it written with `unsigned' first. Using unsigned here is actually bogus. time_t is a signed type in FreeBSD. SUSv3 says "time_t and clock_t shall be integer or real-floating types." In FreeBSD a cast an integer type is safe. Either long or intmax_t are decent choices today. I'd generally prefer intmax_t since that avoids the 2038 bug. We probably will take time_t to 64-bits on all platforms at some time in the future so avoiding the use of longs will save us pain then. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --BXVAT5kNtrzKuDFl Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBRN58XY6L6fI4GtQRAk7cAKDNp+DvpXF8H+LBnXK+aVDJpJcIWgCg4AeI IhdDyygVNfOASYieU3DzNKc= =Op+b -----END PGP SIGNATURE----- --BXVAT5kNtrzKuDFl--