Date: Sun, 30 Apr 2023 18:31:23 -0800 From: Rob Wing <rob.fx907@gmail.com> To: Matthew Grooms <mgrooms@shrew.net> Cc: freebsd-hackers@freebsd.org, freebsd-virtualization@freebsd.org, elenamihailescu22@gmail.com, Mihai Carabas <mihai.carabas@gmail.com>, gusev.vitaliy@gmail.com Subject: Re: BHYVE_SNAPSHOT Message-ID: <CAF3%2Bn_fN4J4jXH89t8gMOD8QpqAike0Uzrb9wUfKoYv56zQt_w@mail.gmail.com> In-Reply-To: <fe221c6a-acb7-ddbd-413d-7039de33e872@shrew.net> References: <ZEz8tU_83QfqbbMu@int21h> <fe221c6a-acb7-ddbd-413d-7039de33e872@shrew.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000f8434305fa989d84 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hey Matthew, On Sun, Apr 30, 2023 at 1:41=E2=80=AFPM Matthew Grooms <mgrooms@shrew.net> = wrote: > > Would you like to see support for VM snapshots in the generic kernel? > Is there a review open that addresses the limitations described in the commit message that brought the snapshot feature in? https://github.com/freebsd/freebsd-src/commit/483d953a86a2507355f8287c5107d= c827a0ff516 > How about support for warm or live migration? This builds off the snapshot work, right? Seems like it'd make more sense to address the current limitations of the snapshot code before extending the functionality off the top of it. > There are experimental patches for all these features that were developed > by students at UPB. In a lot of cases, there are open reviews that have > been waiting on feedback for ages. > In general, most people don't want to review large experimental patches. > The case is quite plain. I'm not sure what the solution is to this > problem. I'd love to hear feedback from the community about how I've got > this completely wrong and how the course could be corrected. That would > be something. > My perspective is that it would have been better to focus student efforts on completing the snapshot feature. By completing the snapshot feature, I mean getting the code into a state where it's compiled in by default and no longer considered an experimental feature. -Rob --000000000000f8434305fa989d84 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>Hey Matthew,<br></div><br><div class=3D"gmail_quote">= <div dir=3D"ltr" class=3D"gmail_attr">On Sun, Apr 30, 2023 at 1:41=E2=80=AF= PM Matthew Grooms <<a href=3D"mailto:mgrooms@shrew.net">mgrooms@shrew.ne= t</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin= :0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"= > <br> Would you like to see support for VM snapshots in the generic kernel?<br></= blockquote><div><br></div><div>Is there a review open that addresses the li= mitations described in the commit message that brought the snapshot feature= in? <a href=3D"https://github.com/freebsd/freebsd-src/commit/483d953a86a25= 07355f8287c5107dc827a0ff516">https://github.com/freebsd/freebsd-src/commit/= 483d953a86a2507355f8287c5107dc827a0ff516</a></div><div>=C2=A0</div><blockqu= ote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px= solid rgb(204,204,204);padding-left:1ex"> How about support for warm or live migration?</blockquote><div><br></div><d= iv>This builds off the snapshot work, right? Seems like it'd make more = sense to address the current limitations of the snapshot code before extend= ing the functionality off the top of it.<br></div><div>=C2=A0</div><blockqu= ote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px= solid rgb(204,204,204);padding-left:1ex">There are experimental patches fo= r all these features that were developed by students at UPB. In a lot of ca= ses, there are open reviews that have been waiting on feedback for ages.<br= ></blockquote><div><br></div><div>In general, most people don't want to= review large experimental patches.<br></div><div>=C2=A0<br></div><blockquo= te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px = solid rgb(204,204,204);padding-left:1ex"> The case is quite plain. I'm not sure what the solution is to this <br> problem. I'd love to hear feedback from the community about how I'v= e got <br> this completely wrong and how the course could be corrected. That would <br= > be something.<br></blockquote><div><br></div><div>My perspective is that it= would have been better to focus student efforts on completing the snapshot= feature. By completing the snapshot feature, I mean getting the code into = a state where it's compiled in by default and no longer considered an e= xperimental feature.</div><div><br></div><div>-Rob<br></div></div></div> --000000000000f8434305fa989d84--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF3%2Bn_fN4J4jXH89t8gMOD8QpqAike0Uzrb9wUfKoYv56zQt_w>