From owner-freebsd-bugs@FreeBSD.ORG Tue Mar 9 10:40:19 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 28F1B16A4CF for ; Tue, 9 Mar 2004 10:40:19 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 064AD43D4C for ; Tue, 9 Mar 2004 10:40:19 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i29IeIbv048368 for ; Tue, 9 Mar 2004 10:40:18 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i29IeIH3048367; Tue, 9 Mar 2004 10:40:18 -0800 (PST) (envelope-from gnats) Resent-Date: Tue, 9 Mar 2004 10:40:18 -0800 (PST) Resent-Message-Id: <200403091840.i29IeIH3048367@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Christian S.J.Peron" Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5823E16A4CE for ; Tue, 9 Mar 2004 10:36:27 -0800 (PST) Received: from staff.seccuris.com (staff.seccuris.com [204.112.0.40]) by mx1.FreeBSD.org (Postfix) with SMTP id B8A3843D41 for ; Tue, 9 Mar 2004 10:36:26 -0800 (PST) (envelope-from cperon@staff.seccuris.com) Received: (qmail 36431 invoked by uid 1006); 9 Mar 2004 18:36:25 -0000 Message-Id: <20040309183625.36430.qmail@staff.seccuris.com> Date: 9 Mar 2004 18:36:25 -0000 From: "Christian S.J.Peron" To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/64001: [patch] ENSONIQ interrupt handler contains if eval with no effect X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: "Christian S.J.Peron" List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Mar 2004 18:40:19 -0000 >Number: 64001 >Category: kern >Synopsis: [patch] ENSONIQ interrupt handler contains if eval with no effect >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Mar 09 10:40:18 PST 2004 >Closed-Date: >Last-Modified: >Originator: Christian S.J. Peron >Release: FreeBSD 4.8-RELEASE-p13 i386 >Organization: >Environment: System: FreeBSD movl 4.8-RELEASE-p13 FreeBSD 4.8-RELEASE-p13 #1: Sat Oct 25 16:45:55 UTC 2003 i@movl:/usr/src/sys/compile/STAFF i386 >Description: Although it is not that big of a deal, there is an if evaluation with no effect in the interrupt handler of the ENSONIQ driver. The semi-colon terminates the if construct. I have commented it out, but you may just want to delete it all together. >How-To-Repeat: N/A >Fix: --- sys/dev/sound/pci/es137x.c.bak Tue Mar 9 18:27:18 2004 +++ sys/dev/sound/pci/es137x.c Tue Mar 9 18:29:22 2004 @@ -465,7 +465,7 @@ bus_space_write_4(es->st, es->sh, ES1370_REG_SERIAL_CONTROL, es->sctrl); if (intsrc & STAT_ADC) chn_intr(es->rch.channel); - if (intsrc & STAT_DAC1); + /* if (intsrc & STAT_DAC1); */ if (intsrc & STAT_DAC2) chn_intr(es->pch.channel); } >Release-Note: >Audit-Trail: >Unformatted: