From owner-freebsd-current@freebsd.org Sat Oct 20 07:46:25 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 407C2FFC809 for ; Sat, 20 Oct 2018 07:46:25 +0000 (UTC) (envelope-from aliovx@gmail.com) Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9D88382C52 for ; Sat, 20 Oct 2018 07:46:24 +0000 (UTC) (envelope-from aliovx@gmail.com) Received: by mail-ot1-x342.google.com with SMTP id 14so31384560oth.2 for ; Sat, 20 Oct 2018 00:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KvN/G+/umJkllsrB8ygB07u1f6T7fdMzttzCRWCN+p0=; b=dCq05Q75/+M8EmpFOsyLhmaGTEGtOQQEEODfm32j8Evfo/ZKW/rRe0tnLEua3dXNEK USKssk7Koq671GNxPOugdiGJUGEbKjg8cfnfzhA/ao01gKl9x+Budds62AeaOgI2Kuo/ j9cHItsufPp1sTkvLyfLzfmsQlSW48ZqtOHDWNHy1taqYGEjgpOyeEKa9fnWP4wYci6W RFtyYZIOpd2hwqPLqBuH3iwnsDlnzgUZFDHJZONBPXLzUAJ8pfSthQQfjoKBX3Psws3k S22Z9bFavIUwnFw4PGqIR3xE//cgkb9Cl/rR7NXGqIqo8ctm97YRY9iLIPACrRUQl7gO hm0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KvN/G+/umJkllsrB8ygB07u1f6T7fdMzttzCRWCN+p0=; b=gUENuLqPRb255zjnp9jMaaG4GzO8TDuzcPpm5rn2GPqZfD7F9OCRUKjVWEYvZ1QrmL yeBhXj+KbzZhjFCe5jXi00mEJgN4EDc9Dvz2yTqcIjZv942lO1Hyh+t41prmu5+IAjQv Cl6263DtLHfgcAWvRZpkruKIK73Gz/r1LgQIaLrQdva1RklsjBHdHftYAEcW5prsUjea TsXypli9g2MkMMAiMMdD96lRdGbDtOoS+fmm7T/3+XxDXCrwQq1UiivOCXjkKk2xIUHs eICCI4UdvSaLhPP7tI7mNJ4DIfDy3H31h8loe21SJvWTBb2SZrKqvK/I+YRcG+uSvMRz O4Eg== X-Gm-Message-State: ABuFfogiOrwHzxCLG65E90NP8k59z8Y1pg6FFKBACcfT6JZtiOo1XDxS bjREzQh4i+csW9yyKzF6kj3TCStQYTCHIDlWhfU= X-Google-Smtp-Source: ACcGV62iylHLrelxCTGWb8I0NnckSHBSXzUhVHFyw7i13eidqiaqulZ6iAtiNklKjzspvI09hTlIl7xsQTBYNkCYVvk= X-Received: by 2002:a9d:419a:: with SMTP id p26mr26105342ote.9.1540021583932; Sat, 20 Oct 2018 00:46:23 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ali Abdallah Date: Sat, 20 Oct 2018 09:46:11 +0200 Message-ID: Subject: Re: fuser does not list id of processes that have a file To: Mateusz Guzik Cc: Ed Schouten , freebsd-current Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2018 07:46:25 -0000 >> I tested on zfs, perhaps there is something extra going on on other filesystems. I tested on UFS2, and I get nothing out of the patched fuser.c. On Thu, Oct 18, 2018 at 11:24 PM Mateusz Guzik wrote: > On 10/17/18, Ali Abdallah wrote: > >> diff --git a/usr.bin/fstat/fuser.c b/usr.bin/fstat/fuser.c > >> index b4225328fc1f..17d06f1c5b13 100644 > >> --- a/usr.bin/fstat/fuser.c > >> +++ b/usr.bin/fstat/fuser.c > >> @@ -92,7 +92,7 @@ struct consumer { > >> STAILQ_ENTRY(consumer) next; > >> }; > >> struct reqfile { > >> - uint32_t fsid; > >> + uint64_t fsid; > >> uint64_t fileid; > >> const char *name; > >> STAILQ_HEAD(, consumer) consumers; > > > > The above patch does not resolve the problem for me. > > > > Are you sure you recompiled and reinstalled the tool with the patch > applied? > You can recompile and install like this: > # make -j 3 clean all install > > If this indeed still does not work, can you show output of: > uname -m > mount > > I tested on zfs, perhaps there is something extra going on on other > filesystems. > > -- > Mateusz Guzik >