From owner-svn-src-head@FreeBSD.ORG  Mon Jan 12 16:16:51 2015
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 5B9ABE9C;
 Mon, 12 Jan 2015 16:16:51 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id D3BE414F;
 Mon, 12 Jan 2015 16:16:49 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t0CGGliW020854
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Mon, 12 Jan 2015 19:16:47 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t0CGGl4w020853;
 Mon, 12 Jan 2015 19:16:47 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Mon, 12 Jan 2015 19:16:47 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Adrian Chadd <adrian@freebsd.org>
Subject: Re: svn commit: r277072 - head/sys/netinet6
Message-ID: <20150112161647.GQ15484@FreeBSD.org>
References: <201501121452.t0CEqihQ050794@svn.freebsd.org>
 <54B3E3BE.7090302@FreeBSD.org>
 <CAJ-VmomiG8kZEVjEupqT61nHijPkOBZ21fqz6KqumyVH3vi3WQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJ-VmomiG8kZEVjEupqT61nHijPkOBZ21fqz6KqumyVH3vi3WQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "Alexander V. Chernikov" <melifaro@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Jan 2015 16:16:51 -0000

On Mon, Jan 12, 2015 at 08:09:18AM -0800, Adrian Chadd wrote:
A> On 12 January 2015 at 07:09, Alexander V. Chernikov
A> <melifaro@freebsd.org> wrote:
A> > On 12.01.2015 17:52, Gleb Smirnoff wrote:
A> >> Author: glebius
A> >> Date: Mon Jan 12 14:52:43 2015
A> >> New Revision: 277072
A> >> URL: https://svnweb.freebsd.org/changeset/base/277072
A> >>
A> >> Log:
A> >>   Do not go one layer down to check ifqueue length. First, not all drivers
A> >>   use ifqueue at all. Second, there is no point in this lockless check.
A> >>   Either positive or negative result of the check could be incorrect after
A> >>   a tick.
A> > Finally, no useless ifq_maxlen check!
A> 
A> Yeah, I killed it in the ipv4 world. Well, commented it out. It's been
A> bogus ever since kernels became re-entrant and SMP. :(

Another one (even with extra mistake) left in ip_fastfwd.c until today.

One still left in SCTP output code, waiting for maintainers to review it.

-- 
Totus tuus, Glebius.