From owner-freebsd-current@FreeBSD.ORG Sat Jan 24 00:30:27 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 221C5EC1 for ; Sat, 24 Jan 2015 00:30:27 +0000 (UTC) Received: from smtpout1.timeweb.ru (smtpout1.timeweb.ru [92.53.117.15]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C8188BA9 for ; Sat, 24 Jan 2015 00:30:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=amdmi3.ru; s=dkim; h=Content-Type:MIME-Version:Message-ID:Subject:To:From:Date; bh=tOq3z/Dz9/c6k+HcMZPZXLJiDpejvBb78izcfc7RLZc=; b=YFyGLpRV46pY3hphZXIetusVDbOYL4cu7bxBwHdJlFc4OBd2TxqzHhgj740hzAZOMkCJK2yweJEzApa+WP3YnGxMc3QVCHZZ4Q8lJXm1JqaaSCnRMGX2mU0cTahtGOVioKzGkEj/dLKR4uGiKcluhKXx3XzqAtuNLmvFRrIltIo=; Received: from [213.148.20.85] (helo=hive.panopticon) by smtp.timeweb.ru with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1YEocD-0003Hp-0Z for freebsd-current@FreeBSD.org; Sat, 24 Jan 2015 03:30:17 +0300 Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id 68993209 for ; Sat, 24 Jan 2015 03:29:40 +0300 (MSK) Received: by hades.panopticon (Postfix, from userid 1000) id 20D9C787D; Sat, 24 Jan 2015 03:29:56 +0300 (MSK) Date: Sat, 24 Jan 2015 03:29:56 +0300 From: Dmitry Marakasov To: freebsd-current@FreeBSD.org Subject: OptionalObsoleteFiles.inc completeness improvement, try 2 Message-ID: <20150124002956.GI1101@hades.panopticon> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Jan 2015 00:30:27 -0000 Hi! Some years ago I've started a project of improving OptionalObsoleteFiles.inc completeness, which allows make delete-old / delete-old-libs / delete-old-dirs targets completelty remove files which are normally installed when specific src.conf WITHOUT_* knobs are set. In other words, if a user has some WITHOUT_* set in src.conf, specific files are not installed by installworld, but not removed by remove-old, which I try to fix. In yet other words, I want to make it so `make installworld -DWITHOUT_foo=yes` and `make installworld && make delete-old -DWITHOUT_foo=yes` result in the very same file sets. Though the project seems to be useful and have real demand (added to IdeasPage by netchild@, though removed later by brooks@ [1]) and interest ([2]), the change was ignored back then and now the patch is completely rotten. I can redo it, but I need a reviewer. Here's a first small part of the patch: https://reviews.freebsd.org/D1600 The WIP branch with other changes is [3] Also there is a question of delete-old-dirs removing directories which are created by mtree run by installworld unconditionally. This seems to be incorrect - either directories should be installed conditionally or not removed by delete-old-dirs. My patch will address this issue as well, by not remiving unconditionally installed dirs. [1] https://wiki.freebsd.org/action/diff/IdeasPage?action=diff&rev1=260&rev2=261 [2] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=168341#c6 [3] https://github.com/AMDmi3/freebsd/compare/obsolete-files -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru