From owner-freebsd-questions@FreeBSD.ORG Tue Mar 30 17:08:35 2010 Return-Path: Delivered-To: freebsd-questions@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A4293106566B for ; Tue, 30 Mar 2010 17:08:35 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.freebsd.org (Postfix) with ESMTP id 1DB7E8FC0C for ; Tue, 30 Mar 2010 17:08:34 +0000 (UTC) X-Spam-Status: No X-Hellug-MailScanner-From: keramida@ceid.upatras.gr X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-2.9, required 5, autolearn=not spam, ALL_TRUSTED -1.00, BAYES_00 -1.90) X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-ID: o2UH8CZO009896 Received: from kobe.laptop (ppp-94-64-219-161.home.otenet.gr [94.64.219.161]) (authenticated bits=128) by igloo.linux.gr (8.14.3/8.14.3/Debian-9.1) with ESMTP id o2UH8CZO009896 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 30 Mar 2010 20:08:18 +0300 Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.4/8.14.4) with ESMTP id o2UH87ua098419 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 30 Mar 2010 20:08:07 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) Received: (from keramida@localhost) by kobe.laptop (8.14.4/8.14.4/Submit) id o2UEwDXN002713; Tue, 30 Mar 2010 17:58:13 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) From: Giorgos Keramidas To: Adam PAPAI References: <4BA3F8C1.1010606@wooh.hu> Date: Tue, 30 Mar 2010 17:58:13 +0300 In-Reply-To: <4BA3F8C1.1010606@wooh.hu> (Adam PAPAI's message of "Fri, 19 Mar 2010 23:20:49 +0100") Message-ID: <874ojx6em2.fsf@kobe.laptop> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: freebsd-questions@freebsd.org Subject: Re: How to send a patch in a proper way? X-BeenThere: freebsd-questions@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: User questions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Mar 2010 17:08:35 -0000 On Fri, 19 Mar 2010 23:20:49 +0100, Adam PAPAI wrote: > Hi, > > As of today I'll try to help and create bugfix patches for usr/src and > usr/ports. > > I've already done 2 patches and posted it to the -current list but > don't really know what is the best way to post the patches. Who will > "check" them? who will make the decision to use them? How should I > send the patches? diff -u full path or relative path? > > Is there any FAQ about this issue? The appropriate path is often a judgement call for you. I usually send patches that include at least *part* of the pathname, e.g. when patches for ports are created I diff at the toplevel /usr/ports tree, so that both the port-categogy and the port-name are visible in the patch file. When generating patches for the /usr/src tree it is also useful to see the relative path under /usr/src, e.g. I try to use: cd /usr/src diff -ruN bin/ls.orig bin/ls When the pathname of the source subdirectory is trivial to infer from the name of the utility itself you can also just diff files inside the source of the utility itself: cd /usr/src/bin/ls diff -u ls.c.orig ls.c You shouldn't worry too much about pathname context though. The FreeBSD developers will ask for more details if they cannot understand what you are patching. A couple of email iterations later you'll both know what is being patched where it was patched, and so on.