From owner-freebsd-bluetooth@FreeBSD.ORG  Fri Nov  7 21:00:06 2008
Return-Path: <owner-freebsd-bluetooth@FreeBSD.ORG>
Delivered-To: freebsd-bluetooth@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 334FE1065672
	for <freebsd-bluetooth@freebsd.org>;
	Fri,  7 Nov 2008 21:00:06 +0000 (UTC)
	(envelope-from plunky@rya-online.net)
Received: from smtp01.one2one.net (smtp01.one2one.net [149.254.200.196])
	by mx1.freebsd.org (Postfix) with ESMTP id DA8A38FC22
	for <freebsd-bluetooth@freebsd.org>;
	Fri,  7 Nov 2008 21:00:05 +0000 (UTC)
	(envelope-from plunky@rya-online.net)
Received: from [127.0.0.1] (helo=localhost)
	by smtpbarns01 with esmtp (Exim 4.50)
	id 1KyYQy-0003oy-EQ; Fri, 07 Nov 2008 21:00:00 +0000
Received: from smtpbarns01 ([127.0.0.1])
	by localhost (smtpbarns01 [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 14620-03; Fri, 7 Nov 2008 21:00:00 +0000 (GMT)
Received: from [10.199.59.87] (helo=rya-online.net)
	by smtpbarns01 with smtp (Exim 4.50)
	id 1KyYQv-0003on-Uf; Fri, 07 Nov 2008 21:00:00 +0000
Received: (nullmailer pid 659 invoked by uid 1000);
	Fri, 07 Nov 2008 20:58:41 -0000
Date: Fri, 7 Nov 2008 20:58:40 +0000 (GMT)
To: Guido Falsi <mad@madpilot.net>
In-Reply-To: <4910CA97.6030708@madpilot.net>
References: <20081104111947.GB62907@megatron.madpilot.net>
	<1225799105.807983.1164.nullmailer@galant.ukfsn.org>
	<20081104135107.GA64776@megatron.madpilot.net>
	<1225821264.107584.759.nullmailer@galant.ukfsn.org>
	<4910B6E6.7070206@madpilot.net> <4910CA97.6030708@madpilot.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Message-Id: <1226091521.039371.399.nullmailer@galant.ukfsn.org>
From: Iain Hibbert <plunky@rya-online.net>
X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at example.com
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: plunky@rya-online.net
X-SA-Exim-Scanned: No (on smtpbarns01); SAEximRunCond expanded to false
Cc: freebsd-bluetooth@freebsd.org
Subject: Re: RFComm behaviour with nokia mobiles
X-BeenThere: freebsd-bluetooth@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Using Bluetooth in FreeBSD environments
	<freebsd-bluetooth.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bluetooth>, 
	<mailto:freebsd-bluetooth-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bluetooth>
List-Post: <mailto:freebsd-bluetooth@freebsd.org>
List-Help: <mailto:freebsd-bluetooth-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bluetooth>, 
	<mailto:freebsd-bluetooth-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Nov 2008 21:00:06 -0000

On Tue, 4 Nov 2008, Guido Falsi wrote:

> Guido Falsi wrote:
>
> > As I said, that was my mistake. Anyway I thank you a lot because you gave me
> > the idea where to look for mistakes. I should be able to get gnokii to work
> > now. Thank you a lot again!
>
> I've just submitted a PR for the gnokii port. If someone feels like checking
> my work(it does need checking I think) it's here:

The attribute ID list should be in ascending order according to the
specification. This means though that some logic could be wrong because
the protocol descriptor list for any given service class would likely
appear before the service name in the response attribute list and you
would use the wrong channel..

probably you should do it like:

	channel = -1;

	switch (attribute) {
	case PROTOCOL_DESCRIPTOR_LIST
		channel = <...>;
		break;

	case SERVICE_NAME
		if (channel == -1)
			break;

		str = <...>;

		if (strncmp(str, "...")) {
			channel = -1;
			break;
		}

		return success;
	}

?

also, instead of providing two calls to the find_service_channel()
function, just put

#ifdef SDP_SERVICE_CLASS_SERIAL_PORT
#define SERIAL_PORT_SVCLASS_ID SDP_SERVICE_CLASS_SERIAL_PORT
#endif

at the top which cuts down on unreadable alternatives?

iain