From owner-svn-src-all@FreeBSD.ORG  Sun Nov 13 05:26:56 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B5732106564A;
	Sun, 13 Nov 2011 05:26:56 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id A3F2A8FC08;
	Sun, 13 Nov 2011 05:26:56 +0000 (UTC)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id E31A61A3C84; Sat, 12 Nov 2011 21:11:07 -0800 (PST)
Date: Sat, 12 Nov 2011 21:11:07 -0800
From: Alfred Perlstein <alfred@freebsd.org>
To: Garrett Cooper <yanegomi@gmail.com>
Message-ID: <20111113051107.GA94817@elvis.mu.org>
References: <201111130318.pAD3IvGr074144@svn.freebsd.org>
	<32EF12FA-07AC-481C-A407-3C8B578484C4@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <32EF12FA-07AC-481C-A407-3C8B578484C4@gmail.com>
User-Agent: Mutt/1.4.2.3i
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r227483 - head/usr.sbin/portsnap/portsnap
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Nov 2011 05:26:56 -0000

* Garrett Cooper <yanegomi@gmail.com> [111112 19:25] wrote:
> On Nov 12, 2011, at 7:18 PM, Alfred Perlstein wrote:
> 
> > Author: alfred
> > Date: Sun Nov 13 03:18:57 2011
> > New Revision: 227483
> > URL: http://svn.freebsd.org/changeset/base/227483
> > 
> > Log:
> >  Utilize shell's IFS instead of forking ~6 processes to
> >  handle splitting input files on a '|'.  This greatly
> >  reduces the time taken to process several databases
> >  during the update process.
> > 
> >  Additionally add some more debug logging.
> > 
> > Modified:
> >  head/usr.sbin/portsnap/portsnap/portsnap.sh
> > 
> 
> 	Wouldn't
> 
> oldIFS=$IFS
> # Blah blah
> IFS=$oldIFS
> 
> 	be better?

Meh, it's hard to do it in some of the code because of the
'return' in the middle of the logic and in the other places
I didn't really care that much.

That said, I'll happily take a patch to clean it up some.

Just watch the logic, it's hairy in the places I used
'local'.

-- 
- Alfred Perlstein
.- VMOA #5191, 03 vmax, 92 gs500, 85 ch250, 07 zx10
.- FreeBSD committer