From owner-freebsd-ports@FreeBSD.ORG Tue Apr 2 17:49:52 2013 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 4C236E0F; Tue, 2 Apr 2013 17:49:52 +0000 (UTC) (envelope-from villa.alberto@gmail.com) Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by mx1.freebsd.org (Postfix) with ESMTP id 6B4F137E; Tue, 2 Apr 2013 17:49:51 +0000 (UTC) Received: by mail-ee0-f49.google.com with SMTP id d41so353123eek.8 for ; Tue, 02 Apr 2013 10:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version:content-type :content-transfer-encoding; bh=cSEi4wo+3CsPEU9bKRmhACKAdg96Xv+dlLofMWhCSR4=; b=0c7CLepDZQKYuOFPLpf4+dOIyVFoXH+rtqUzZcHVmFq6qGj4EwQXIACE3GilWbbW5c d7b2fdCKM93VQurOiTkCryDgsio4ZPJMTBhsIs6eAYp/TcNNXehuNTAN0WmPqJ7VnK2t ptZWcKntQJFJFuhIjy58uAfvAPNvBG2u4zP5lrmU3k89TolsEoitWJ5iyz9pNvQ5H8Fl I3g80azm1izKqP5G1IOLLtrFBspVKQsuu30ediYPHqqej7dFsisgD6PLHfhhY3FGjJqA zpPaVnCCZDNuC5J8cfA2cjNAinc0Qhr53fw8Gr99rSb4FJ/IiOnkeeOu30qJG3FUsC3Q 6Y4A== X-Received: by 10.14.210.132 with SMTP id u4mr2774154eeo.19.1364924990354; Tue, 02 Apr 2013 10:49:50 -0700 (PDT) Received: from indiana.smith (ppp-251-55.33-151.iol.it. [151.33.55.251]) by mx.google.com with ESMTPS id d47sm4084958eem.9.2013.04.02.10.49.48 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 02 Apr 2013 10:49:49 -0700 (PDT) Sender: Alberto Villa From: Alberto Villa To: Baptiste Daroussin Subject: Re: [kde-freebsd] py27-pykde4-4.10.1 Date: Tue, 02 Apr 2013 19:49:35 +0200 Message-ID: <2804828.qOu8dtiYNA@indiana.smith> Organization: The FreeBSD Project User-Agent: KMail/4.9.5 (FreeBSD/10.0-CURRENT; KDE/4.9.5; amd64; ; ) In-Reply-To: <20130402172440.GM56166@ithaqua.etoilebsd.net> References: <1505116.DpgL6T9iEl@luna.wi.rr.com> <12878738.sI6p4J2xBi@indiana.smith> <20130402172440.GM56166@ithaqua.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart80291812.fK7XhfGevH"; micalg="pgp-sha1"; protocol="application/pgp-signature" Content-Transfer-Encoding: 7Bit Cc: Koop Mast , freebsd-ports@freebsd.org, kde-freebsd@kde.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2013 17:49:52 -0000 --nextPart80291812.fK7XhfGevH Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Tuesday 02 April 2013 19:24:40 Baptiste Daroussin wrote: > bsd.options.mk can't anyway be loaded after bsd.port.pre.mk given that one > may want to provide a PYTHON option and will make it set USE_PYTHON=yes for > example. Sure, you're right. > I don't know the right fix to be honnest. But UNIQUENAME not being UNIQUE is > a real problem imho and OPTIONSFILE changing depending on being after > pre.mk or before pre.mk is another problem. As far as I know LATEST_LINK should be unique (there was also a service checking for duplicates)... What about UNIQUENAME=${LATEST_LINK}? Anyway the problem is not with UNIQUENAME, it's with the usage of PKGNAMESUFFIX. PKGNAMESUFFIX should be used by ports sharing the same OPTIONS but with light differencies (e.g., variations of a single port); it would be perfect. Unfortunately, time passed and it started being used the wrong (so wrong) way. Either PKGNAMESUFFIX usage is fixed (among >20k ports!), or UNIQUENAME is set to LATEST_LINK (or similar). About the loading order, yes, it needs serious thought. At the same time, many *.mk files need to be fixed as they don't distinguish between pre- and post- makefile sections. Some day a vademecum has to be written about those two sections, and I volunteer to help with that as I studied the matter quite well in the past. -- Alberto Villa, FreeBSD committer http://people.FreeBSD.org/~avilla There are two problems with a major hangover. You feel like you are going to die and you're afraid that you won't. --nextPart80291812.fK7XhfGevH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iJwEAAECAAYFAlFbGjIACgkQ3xiC6kQ1CosovwQAlONed0hRmtS0oJRTxH+9+flt QWNyUsYaLh4H6VXvH2JL36qX+9L2f86Eg5WI6yCnFfm8lhl0sux+ODuwQnaNFqzr BK24VkGyzQ8kHHXQy6JiWl/hh6NUFi2gnKL9WdDhQDcE1mJn9R66hlFt3wGmp7uD ZVgzSvn2s+2+Y1RnVNc= =LVWY -----END PGP SIGNATURE----- --nextPart80291812.fK7XhfGevH--