From owner-cvs-all  Mon Jul 23  5:17:30 2001
Delivered-To: cvs-all@freebsd.org
Received: from assaris.sics.se (assaris.sics.se [193.10.66.234])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3BA1937B405; Mon, 23 Jul 2001 05:17:25 -0700 (PDT)
	(envelope-from assar@assaris.sics.se)
Received: (from assar@localhost)
	by assaris.sics.se (8.9.3/8.9.3) id OAA38691;
	Mon, 23 Jul 2001 14:17:17 +0200 (CEST)
	(envelope-from assar)
To: Bruce Evans <bde@zeta.org.au>
Cc: Warner Losh <imp@harmony.village.org>,
	Wes Peters <wes@softweyr.com>, Brian Somers <brian@Awfulhak.org>,
	cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libutil ecalloc.c emalloc.3 emalloc.c erealloc.c estrdup.c Makefile libutil.h
References: <Pine.BSF.4.21.0107232048460.32891-100000@besplex.bde.org>
From: Assar Westerlund <assar@FreeBSD.org>
Date: 23 Jul 2001 14:17:13 +0200
In-Reply-To: Bruce Evans's message of "Mon, 23 Jul 2001 21:14:06 +1000 (EST)"
Message-ID: <5lelr7x2k5.fsf@assaris.sics.se>
Lines: 26
User-Agent: Gnus/5.070098 (Pterodactyl Gnus v0.98) Emacs/20.6
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

Bruce Evans <bde@zeta.org.au> writes:
> Yes, most exit() and err*() calls in libraries are bugs.

Hm.  lib/libutil/login_auth.c:auth_checknologin and there seems to be
some more.

> Other problems with this idea:
> - the new functions don't belong in libutil for various reasons:
>   + libutil should not be a home for miscellaneous functions.
>   + shared linkage to another library is a pessimization (always in
>     time and perhaps in space too).

Where do they belong?  Having them in every program seems a
pessimization too.

> - these functions are often named xmalloc(), etc. (e.g., in gnu utilities).
>   Are you going to changes all these too?  (Certainly not in contrib).

I don't think we should modify contrib/* code to use such functions.

> I noticed new copies of these functions growing faster than the initial
> version of this change was reviewed.  There is another set in rcorder.

Yes.

/assar

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message