From nobody Fri Jan 21 13:16:57 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 159F8196708F for ; Fri, 21 Jan 2022 13:16:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JgKfK57MXz4pDC for ; Fri, 21 Jan 2022 13:16:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8E8FE1C75D for ; Fri, 21 Jan 2022 13:16:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 20LDGvta054973 for ; Fri, 21 Jan 2022 13:16:57 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 20LDGvXj054972 for bugs@FreeBSD.org; Fri, 21 Jan 2022 13:16:57 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 261377] mrsas: Firing DCMDs while controller reset leads to firmware FMU error Date: Fri, 21 Jan 2022 13:16:57 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: chandrakanth.patil@broadcom.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1642771017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OUWfnmsL2t1hDLd5K6tHrdNHkAq37rVWtxk5vB8Yuyg=; b=cNI920YdV2J6fraJpT2vgl6zXfN9+08jrDeTDn3aKfP4WWSuxgVqDkXhMxu4FrZ6xoZVNM IfnPkPHdOGbtGZNx2D7/0SY2vRzq2EUbzXr8qtuiJI/QK6WBVzzXfQxjnPl4ZrJEuxz7z7 +RHFPy3m5/B56aVK01lwWEoTZAScN+T5+4AvX0mcppKXBPwywIix/W7Ih8QTFT4CsUTe3m Js0DWHmn18aUkvCrNCpX9BE5L1f8XH+hjERo18aMgiL815Tw0XHtlHWw7VpBViDiHXcoE5 9gS7x4HxVugFZe4C+Y9w8UnbKyz3knBjUc8nhvqUT21ZqEVzBH74/bSKxWn66w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1642771017; a=rsa-sha256; cv=none; b=gU7hQou35T6tC2V+9ej/ZAhE9r9BKIqQyWdLQMx7RRfIh496vgcR4UExnzjV7WvhmMKyEL b4f7k/tmsDgBof2DNIRq10krQeuJ5CkWDVbte9z6mrf69vLPntdgD0LvRx5ser0AwJDW1o eEQNmPtG2BKTowBx2aYhRdYC4Z6XwyGghIUQuETknhe552vCGfZC7lD8Fn8DfZ0prfh+x+ w4Q1yrmj/nyPmWriQbVljUiqyINc12d0bA/9B9+fqpozfXbbCSEaHwFX1eSpWgduP712j8 taJSGRe6g3LTUuPpegmo0/IgQ3QYPm/0yXqMrmNy3/w/hEkQ66l6LGszsIzYHw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261377 Bug ID: 261377 Summary: mrsas: Firing DCMDs while controller reset leads to firmware FMU error Product: Base System Version: 13.0-RELEASE Hardware: amd64 OS: Any Status: New Severity: Affects Many People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: chandrakanth.patil@broadcom.com Created attachment 231210 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D231210&action= =3Dedit refrain firing DCMDs if controller reset is in progress When controller reset is in progress, a few of the firmware registers are in-accessible state so if drivers access any of those registers at that time will result in undefined behaviour in firmware. In this case, controller reset is in progress, and system shutdown is issue= d, then the shutdown function in the driver will be invoked where it is waiting for a max of 15 sec for a reset to finish and if reset is not finished with= in that time frame then it is going ahead and firing the flush cache and shutd= own DCMDs to firmware which will end up accessing the queues which are not initialised due to undergoing reset leads to FMU error in firmware So fix is to return to OS with proper error from shutdown if controller res= et is not finished after waiting 15 sec. I have attached the patch which will fix this issue.=20 This issue is applicable to variants: 13.0, 13.1, 12.3, 12.1 If possible we can back-port other required variants. --=20 You are receiving this mail because: You are the assignee for the bug.=