From owner-freebsd-bugs@freebsd.org  Sat Jan 14 22:44:16 2017
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DF09ECB0958
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Sat, 14 Jan 2017 22:44:16 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id CE9AD131B
 for <freebsd-bugs@FreeBSD.org>; Sat, 14 Jan 2017 22:44:16 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v0EMiG3P019026
 for <freebsd-bugs@FreeBSD.org>; Sat, 14 Jan 2017 22:44:16 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 216086] An NFSv4.1 client openowner structure is erroneously
 free'd when recovery fails
Date: Sat, 14 Jan 2017 22:44:16 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: rmacklem@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 attachments.created
Message-ID: <bug-216086-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Jan 2017 22:44:17 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D216086

            Bug ID: 216086
           Summary: An NFSv4.1 client openowner structure is erroneously
                    free'd when recovery fails
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: rmacklem@FreeBSD.org

Created attachment 178894
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D178894&action=
=3Dedit
Don't free openowner+opens when a recovery attempt fails

When the NFSv4.1 client attempts recovery from a server crash/reboot and
the new ExchangeID/CreateSession fails 5 times, the code free'd the
openowner structure and cleared the NFSCLFLAGS_HASCLIENTID.

However, it is possible that a process holds the lock on the openowner
at this time and, as such, the openowner should not be free'd.
It also makes sense to keep the opens in case a subsequent recovery
is successful. This scenario would not normally happen, but apparently
does for the AmazonEFS server.

This patch changes the code to not free the openowner + opens and
leave the flag set for the crash/lease_expiry recovery cases.

--=20
You are receiving this mail because:
You are the assignee for the bug.=