From owner-freebsd-current Thu Sep 21 22:13:49 2000 Delivered-To: freebsd-current@freebsd.org Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by hub.freebsd.org (Postfix) with ESMTP id 5F8D737B422; Thu, 21 Sep 2000 22:13:45 -0700 (PDT) Received: (from grog@localhost) by wantadilla.lemis.com (8.11.0/8.9.3) id e8M5DLJ33589; Fri, 22 Sep 2000 14:43:21 +0930 (CST) (envelope-from grog) Date: Fri, 22 Sep 2000 14:43:21 +0930 From: Greg Lehey To: "Brandon D. Valentine" Cc: Matthew Jacob , Poul-Henning Kamp , current@FreeBSD.ORG Subject: Re: 1131 unneeded includes in the kernel... Message-ID: <20000922144321.F66887@wantadilla.lemis.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: ; from bandix@looksharp.net on Wed, Sep 20, 2000 at 03:10:21AM -0400 Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wednesday, 20 September 2000 at 3:10:21 -0400, Brandon D. Valentine wrote: > On Tue, 19 Sep 2000, Matthew Jacob wrote: > >> >> Oh- don't get me wrong. Valuable info. Thanks. > > What would be very cool is to feed this into another script which strips > these unnecesary includes out. Then do a test build of LINT in your > local tree and if it succeeds commit a mass removal of them. The same > concept could be applied to the greater source tree. Things aren't that simple. I've checked some of the vinum ones, and I find something like: #ifdef VINUMDEBUG #include #endif sys/reboot.h has been flagged as unnecessary. Obviously the #ifdef's have to do as well--if the script is correct. There are a number of options in Vinum which never get as far as the source tree. Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message