From owner-freebsd-ports@FreeBSD.ORG Fri Jan 7 18:04:45 2005 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 904A316A4CE for ; Fri, 7 Jan 2005 18:04:45 +0000 (GMT) Received: from minerva.int.gov.br (nat.int.gov.br [200.20.196.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB8C343D5A for ; Fri, 7 Jan 2005 18:04:44 +0000 (GMT) (envelope-from jonny@jonny.eng.br) Received: from [10.0.8.17] (dinf-02 [10.0.8.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by minerva.int.gov.br (Postfix) with ESMTP id A0400BE506; Fri, 7 Jan 2005 16:04:43 -0200 (BRDT) Message-ID: <41DECF3B.70606@jonny.eng.br> Date: Fri, 07 Jan 2005 16:04:43 -0200 From: =?ISO-8859-1?Q?Jo=E3o_Carlos_Mendes_Lu=EDs?= User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Peter Pentchev References: <20050107113259.GB832@straylight.m.ringlet.net> In-Reply-To: <20050107113259.GB832@straylight.m.ringlet.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit cc: ports@freebsd.org Subject: Re: FreeBSD port audio/id3ren update to 1.1b0 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jan 2005 18:04:45 -0000 I see no trouble in the patches. BTW, I no longer follow id3ren development, if you want, please take maintainership for it... Peter Pentchev wrote: > Hi, > > What do you think about the following patch? It updates the id3ren port > to 1.1b0, which is the latest version mentioned on the id3ren site, and > also installs the manual page and some documentation. > > My main reason for looking at newer id3ren versions was support for the > %n track number identifier in the template. Of course, the update will > probably have to wait until the 4.11 ports freeze is over, but still, > here it is :) > > Index: ports/audio/id3ren/Makefile > =================================================================== > RCS file: /home/ncvs/ports/audio/id3ren/Makefile,v > retrieving revision 1.11 > diff -u -r1.11 Makefile > --- ports/audio/id3ren/Makefile 6 Feb 2004 13:10:47 -0000 1.11 > +++ ports/audio/id3ren/Makefile 7 Jan 2005 08:22:21 -0000 > @@ -6,21 +6,31 @@ > # > > PORTNAME= id3ren > -PORTVERSION= 0.97a > +PORTVERSION= 1.1b0 > CATEGORIES= audio > MASTER_SITES= http://cbothamy.free.fr/projects/id3ren/ > -DISTNAME= id3ren97a > +EXTRACT_SUFX= .tgz > > MAINTAINER= jonny@jonny.eng.br > COMMENT= Mpeg Audio Layer 3 util: rename files, edit tags, search, etc > > PLIST_FILES= bin/id3ren > -USE_ZIP= yes > USE_REINPLACE= yes > -WRKSRC= ${WRKDIR}/id3ren/src > +MAN1= id3ren.1 > +MANCOMPRESSED= yes > > pre-patch: > @${REINPLACE_CMD} -e 's,,,' \ > - ${WRKSRC}/id3ren.c ${WRKSRC}/misc.c > + ${WRKSRC}/src/id3ren.c ${WRKSRC}/src/id3misc.c > + ${RM} ${WRKSRC}/src/id3ren > + > +.if !defined(NOPORTDOCS) > +PORTDOCS= AUTHORS ChangeLog FEATURES FEEDBACK INSTALL PORTS \ > + README THANKS TODO USAGE > + > +post-install: > + ${MKDIR} ${DOCSDIR} > + ${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${DOCSDIR} > +.endif > > .include > Index: ports/audio/id3ren/distinfo > =================================================================== > RCS file: /home/ncvs/ports/audio/id3ren/distinfo,v > retrieving revision 1.2 > diff -u -r1.2 distinfo > --- ports/audio/id3ren/distinfo 18 Mar 2004 02:52:42 -0000 1.2 > +++ ports/audio/id3ren/distinfo 7 Jan 2005 08:04:07 -0000 > @@ -1,2 +1,2 @@ > -MD5 (id3ren97a.zip) = 4cb10259b1b523c0f9cd064034fcfaaa > -SIZE (id3ren97a.zip) = 47619 > +MD5 (id3ren-1.1b0.tgz) = dbfe38e5c45d23f6d83a085a0cab7641 > +SIZE (id3ren-1.1b0.tgz) = 42108 > Index: ports/audio/id3ren/files/patch-Makefile > =================================================================== > RCS file: ports/audio/id3ren/files/patch-Makefile > diff -N ports/audio/id3ren/files/patch-Makefile > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ ports/audio/id3ren/files/patch-Makefile 7 Jan 2005 07:57:03 -0000 > @@ -0,0 +1,18 @@ > +--- Makefile.orig Tue Mar 6 02:59:34 2001 > ++++ Makefile Fri Jan 7 09:56:53 2005 > +@@ -1,12 +1,12 @@ > + all: > +- make -C src all > ++ cd src && ${MAKE} all > + > + debug: > + make -C src debug > + > + install: > +- make -C src install > +- make -C man install > ++ cd src && ${MAKE} install > ++ cd man && ${MAKE} install > + > + clean: > + make -C src clean > Index: ports/audio/id3ren/files/patch-aa > =================================================================== > RCS file: /home/ncvs/ports/audio/id3ren/files/patch-aa,v > retrieving revision 1.3 > diff -u -r1.3 patch-aa > --- ports/audio/id3ren/files/patch-aa 29 Apr 2001 23:54:55 -0000 1.3 > +++ ports/audio/id3ren/files/patch-aa 7 Jan 2005 08:09:13 -0000 > @@ -1,26 +1,27 @@ > ---- Makefile.old Wed Mar 18 04:28:44 1998 > -+++ Makefile Sun Feb 28 16:04:16 1999 > -@@ -1,16 +1,17 @@ > --CFLAGS = -O2 -s -Wall > -+CFLAGS += -s -Wall > +--- src/Makefile.orig Fri Jan 7 10:08:02 2005 > ++++ src/Makefile Fri Jan 7 10:08:30 2005 > +@@ -1,9 +1,10 @@ > + CFLAGSDEBUG = -g -O2 -Wall -DDEBUG > +-CFLAGS = -s -O2 -Wall > -CC = gcc > - RM = rm -f > +-RM = rm -f > -INSTALL = install -s -m 755 > --INSTALL_DIR = .. > -+INSTALL = install -cs -m 755 -o root -g wheel > +-INSTALL_DIR = /usr/bin > ++CFLAGS ?= -O2 -Wall > ++STRIP ?= -s > ++CC ?= gcc > ++RM ?= rm -f > ++INSTALL = ${BSD_INSTALL_PROGRAM} > +INSTALL_DIR = ${PREFIX}/bin > INSTALL_NAME = id3ren > > - SOURCES = id3ren.c id3tag.c file.c misc.c > + SOURCES = id3ren.c id3tag.c id3file.c id3misc.c > +@@ -12,7 +13,7 @@ > + all: ${INSTALL_NAME} > > --all: > -+all: ${INSTALL_NAME} > -+ > -+${INSTALL_NAME}: > - ${CC} ${CFLAGS} -o ${INSTALL_NAME} ${SOURCES} > + ${INSTALL_NAME}: ${SOURCES} ${INCLUDES} > +- ${CC} ${CFLAGS} -o ${INSTALL_NAME} ${SOURCES} > ++ ${CC} ${CFLAGS} ${STRIP} -o ${INSTALL_NAME} ${SOURCES} > > --install: all > -+install: ${INSTALL_NAME} > - ${INSTALL} ${INSTALL_NAME} ${INSTALL_DIR}/${INSTALL_NAME} > - > - clean: > + debug: > + ${CC} ${CFLAGSDEBUG} -o ${INSTALL_NAME} ${SOURCES} > Index: ports/audio/id3ren/files/patch-ab > =================================================================== > RCS file: /home/ncvs/ports/audio/id3ren/files/patch-ab,v > retrieving revision 1.1 > diff -u -r1.1 patch-ab > --- ports/audio/id3ren/files/patch-ab 27 Dec 1999 01:02:31 -0000 1.1 > +++ ports/audio/id3ren/files/patch-ab 7 Jan 2005 07:34:28 -0000 > @@ -1,10 +1,10 @@ > ---- id3tag.c.orig Wed Mar 18 17:18:34 1998 > -+++ id3tag.c Sun Dec 26 15:11:42 1999 > -@@ -365,6 +365,7 @@ > - return TRUE; > > - } > > - > > -+ memset(string, 0, size); > > - fgets(string, size, stdin); > > - > > - if (string[strlen(string)-1] == '\n') > > +--- src/id3tag.c.orig Fri Jan 7 09:32:59 2005 > ++++ src/id3tag.c Fri Jan 7 09:33:14 2005 > +@@ -369,6 +369,7 @@ > + return TRUE; > + } > + > ++ memset(string, 0, size); > + fgets(string, size, stdin); > + > + if (string[strlen(string)-1] == '\n') > Index: ports/audio/id3ren/files/patch-man::Makefile > =================================================================== > RCS file: ports/audio/id3ren/files/patch-man::Makefile > diff -N ports/audio/id3ren/files/patch-man::Makefile > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ ports/audio/id3ren/files/patch-man::Makefile 7 Jan 2005 07:54:11 -0000 > @@ -0,0 +1,12 @@ > +--- man/Makefile.orig Fri Jan 7 09:53:38 2005 > ++++ man/Makefile Fri Jan 7 09:53:54 2005 > +@@ -1,6 +1,6 @@ > +-RM = rm -f > +-INSTALL = install -m 755 > +-INSTALL_DIR = /usr/man/man1 > ++RM ?= rm -f > ++INSTALL = ${BSD_INSTALL_MAN} > ++INSTALL_DIR = ${PREFIX}/man/man1 > + INSTALL_NAME = id3ren.1.gz > + > + all: > > G'luck, > Peter > -- -- João Carlos Mendes Luís