From owner-freebsd-gnome@FreeBSD.ORG Thu Feb 26 19:30:58 2009 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7008910656DE for ; Thu, 26 Feb 2009 19:30:58 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from mx0.deglitch.com (backbone.deglitch.com [IPv6:2001:16d8:fffb:4::abba]) by mx1.freebsd.org (Postfix) with ESMTP id 1DFEE8FC1D for ; Thu, 26 Feb 2009 19:30:58 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from DSPAM-Daemon (localhost [127.0.0.1]) by mx0.deglitch.com (Postfix) with SMTP id 3DF088FC51 for ; Thu, 26 Feb 2009 22:30:56 +0300 (MSK) Received: from orion.SpringDaemons.com (drsun1.static.corbina.ru [85.21.245.235]) by mx0.deglitch.com (Postfix) with ESMTPA id CDA388FC4E; Thu, 26 Feb 2009 22:30:55 +0300 (MSK) Received: from orion (localhost [127.0.0.1]) by orion.SpringDaemons.com (Postfix) with SMTP id 4189139B1B; Thu, 26 Feb 2009 22:31:04 +0300 (MSK) Date: Thu, 26 Feb 2009 22:30:59 +0300 From: Stanislav Sedov To: "Andrew W. Nosenko" Message-Id: <20090226223059.9e23c3dc.stas@FreeBSD.org> In-Reply-To: <6161f3180902260653x2a6705l69b36c01b41caca0@mail.gmail.com> References: <20090224021026.ba40bdc2.stas@FreeBSD.org> <1235598615.3297.60.camel@shumai.marcuscom.com> <20090226171804.8681e79c.stas@FreeBSD.org> <6161f3180902260653x2a6705l69b36c01b41caca0@mail.gmail.com> Organization: The FreeBSD Project X-XMPP: ssedov@jabber.ru X-Voice: +7 916 849 20 23 X-PGP-Fingerprint: F21E D6CC 5626 9609 6CE2 A385 2BF5 5993 EB26 9581 X-Mailer: carrier-pigeon Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-DSPAM-Result: Innocent X-DSPAM-Processed: Thu Feb 26 22:30:55 2009 X-DSPAM-Confidence: 1.0000 X-DSPAM-Improbability: 1 in 98689409 chance of being spam X-DSPAM-Probability: 0.0023 X-DSPAM-Signature: 49a6edef967002014410405 Cc: Stanislav Sedov , gnome@freebsd.org Subject: Re: [FreeBSD port]: devel/glib20 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2009 19:31:00 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Thu, 26 Feb 2009 16:53:16 +0200 "Andrew W. Nosenko" mentioned: > On Thu, Feb 26, 2009 at 4:18 PM, Stanislav Sedov wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > On Wed, 25 Feb 2009 16:50:15 -0500 > > Joe Marcus Clarke mentioned: > > > >> On Tue, 2009-02-24 at 02:10 +0300, Stanislav Sedov wrote: > >> > -----BEGIN PGP SIGNED MESSAGE----- > >> > Hash: SHA1 > >> > > >> > Hi! > >> > > >> > glib20 has a known filename encoding problem with non-utf8 > >> > locales, because it doesn't perform names conversion from > >> > internal UTF8 to current locale by default (it used to do > >> > that some time ago). The patch included changes glib20 > >> > behaviour to always do the conversion (this will work > >> > for all non-UTF8 locales and will have no effect fot UTF8 > >> > ones). This is effectively the same redhat & co does in > >> > their deistributions. > >> > > >> > Comments? > >> > >> I have no objection, but I don't typically run into problems with > >> non-UTF-8 locales. I think it would be safer if you made this into an > >> OPTION, and added this as an extra patch if the OPTION is enabled. > >> > > > > Doesn't running gtk/glib (e.g. sylpheed, gimp) apps with non-UTF locale > > break filenames for you? From looking into the code it's always the case > > for non-UTF locales (well, if you running ISO8859-1 you shouldn't have > > problems too). On the other hand enabling LANG-based locale detection should > > not hurt prefromance much (I think the overhead of parsing LANG is neglible). > > Sure, we can OPTIONfy this, but I belive the options should be enabled by > > default in this case (otherwise, people will continue to step onto this > > bug). Major Linux distributions also have this option turned on by default > > to match the behavior of older version of glib where the locale detection > > code was always enabled. > > > > Why you want to patch Glib for turn this behavior on by default > instead of just install file in the /usr/local/etc/profile.d ? > > profile.d approrach is reversible (I can unset enviroment variable), > while patching Glib for remove patch ... slightly ugly at least, > IMHO. > Hmm, I didn't knew about this possible way. What kind of file should be installed here? Is it something specific to glib? Thanks! - -- Stanislav Sedov ST4096-RIPE -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAkmm7fgACgkQK/VZk+smlYE//ACfZbbhjtyOsbI+HielwyDpEALF rK4An0nnpYEX3hHgEldusm2GpkHoMpn7 =2mrR -----END PGP SIGNATURE----- !DSPAM:49a6edef967002014410405!