From owner-freebsd-hackers Sat Nov 23 13:32:54 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 076F637B401 for ; Sat, 23 Nov 2002 13:32:52 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 9847943E3B for ; Sat, 23 Nov 2002 13:32:52 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 77558 invoked by uid 1000); 23 Nov 2002 21:32:53 -0000 Date: Sat, 23 Nov 2002 13:32:53 -0800 (PST) From: Nate Lawson To: Brooks Davis Cc: hackers@FreeBSD.ORG Subject: Re: [brooks@one-eyed-alien.net: [PATCH] switching to if_xname] In-Reply-To: <20021123125056.A10727@Odin.AC.HMC.Edu> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, 23 Nov 2002, Brooks Davis wrote: > On Tue, Nov 19, 2002 at 02:15:34PM -0800, Nate Lawson wrote: > > On Tue, 19 Nov 2002, Brooks Davis wrote: > > > On Fri, Nov 01, 2002 at 10:54:23AM -0800, Brooks Davis wrote: > > > > I'm trying to get some review for the following patch. I realize it's > > > > quite large, but most it is is trivial. The ipfw code is the only thing > > > > that worries me significantly. I have promised Kris that I will fix > > > > ports that break with this change so you don't need to worry about that > > > > issue. > > > > > > I've uploaded a new version of the patch addressing the concerns I've > > > heard to: > > > > > > http://people.freebsd.org/~brooks/patches/if_xname.diff > > > > Thanks for fixing things. Are all the uses of sprintf() below safe and > > intentional? > > No, they weren't intentional. I managed to forget to scan for those. > Most of them were safe, but I've removed all of them. (Grep still hits > a few due to ipf using sprintf). I've uploaded a new version. I'm now > testing a world build on panther. Looks good to me now. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message