From owner-freebsd-standards@FreeBSD.ORG Mon Oct 31 07:56:53 2005 Return-Path: X-Original-To: freebsd-standards@freebsd.org Delivered-To: freebsd-standards@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 69D5916A41F for ; Mon, 31 Oct 2005 07:56:53 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AC43D43D49 for ; Mon, 31 Oct 2005 07:56:52 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9V7uoUk003221; Mon, 31 Oct 2005 18:56:50 +1100 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j9V7umtv023260; Mon, 31 Oct 2005 18:56:49 +1100 Date: Mon, 31 Oct 2005 18:56:48 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Steve Kargl In-Reply-To: <20051030182702.GA18998@troutmask.apl.washington.edu> Message-ID: <20051031184647.Q38664@delplex.bde.org> References: <20051005032400.GA6736@troutmask.apl.washington.edu> <20051005191936.N51036@delplex.bde.org> <20051006212602.GA40609@troutmask.apl.washington.edu> <20051007231439.F58005@delplex.bde.org> <20051007190239.GA78674@troutmask.apl.washington.edu> <20051008052850.S59139@delplex.bde.org> <20051010185153.GA55589@troutmask.apl.washington.edu> <20051012160109.I73531@delplex.bde.org> <20051016184129.GA24651@troutmask.apl.washington.edu> <20051021194624.H598@epsplex.bde.org> <20051030182702.GA18998@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-standards@freebsd.org Subject: Re: complex.h math functions X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Oct 2005 07:56:53 -0000 On Sun, 30 Oct 2005, Steve Kargl wrote: > On Fri, Oct 21, 2005 at 08:50:53PM +1000, Bruce Evans wrote: >> On Sun, 16 Oct 2005, Steve Kargl wrote: >> >>> On Wed, Oct 12, 2005 at 05:23:28PM +1000, Bruce Evans wrote: >> >>> Hopefully, this new version is closer to KNF. >> >> It still has only 4 chars for all secondary indents > > Strange. Hopefully fixed. It's not :-). E.g.: % /* Handle the nearly-non-exceptional cases where x and y are finite. */ % if (ix < 0x7ff00000 && iy < 0x7ff00000) { % if ((iy | ly) == 0) ^^^^ % return (cpack(cosh(x), x * y)); % return (cpack(cosh(x) * cos(y), sinh(x) * sin(y))); % } fdlibm actually mostly uses this style, with all indents 4 chars after the first normal 1-tab one. I don't want to use this for new code and the fdlibm maintainers show signs of switching to normal indentation in k_tan.c. > I also removed the additional > space in the comments after the *. This, of course, will > make a diff fairly large, so I've attached s_ccosh.c. > ... >> The current order is almost that in the standard. This order is not >> bad but it might not give the simplest or shortest classification. >> In particular, I think it might be better to group by 0's before >> grouping by Infs and NaNs. > > I've re-arrange the code to do x = 0 and then y = 0 cases > after the nearly-non-exceptional case. You may want to > flip x = 0 and y = 0. I did not do this because I did not > want to mess up your explanation of choice of signs. I'll merge with it and see if there is more to clean up. Bruce