From owner-cvs-src-old@FreeBSD.ORG Thu Oct 21 19:18:11 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 16F371065673 for ; Thu, 21 Oct 2010 19:18:11 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 04BAE8FC12 for ; Thu, 21 Oct 2010 19:18:11 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id o9LJIAwu014442 for ; Thu, 21 Oct 2010 19:18:10 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id o9LJIAOB014441 for cvs-src-old@freebsd.org; Thu, 21 Oct 2010 19:18:10 GMT (envelope-from jhb@repoman.freebsd.org) Message-Id: <201010211918.o9LJIAOB014441@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to jhb@repoman.freebsd.org using -f From: John Baldwin Date: Thu, 21 Oct 2010 19:17:40 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_exec.c kern_exit.c kern_fork.c kern_ktrace.c src/sys/sys ktrace.h X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2010 19:18:11 -0000 jhb 2010-10-21 19:17:40 UTC FreeBSD src repository Modified files: sys/kern kern_exec.c kern_exit.c kern_fork.c kern_ktrace.c sys/sys ktrace.h Log: SVN rev 214158 on 2010-10-21 19:17:40Z by jhb - When disabling ktracing on a process, free any pending requests that may be left. This fixes a memory leak that can occur when tracing is disabled on a process via disabling tracing of a specific file (or if an I/O error occurs with the tracefile) if the process's next system call is exit(). The trace disabling code clears p_traceflag, so exit1() doesn't do any KTRACE-related cleanup leading to the leak. I chose to make the free'ing of pending records synchronous rather than patching exit1(). - Move KTRACE-specific logic out of kern_(exec|exit|fork).c and into kern_ktrace.c instead. Make ktrace_mtx private to kern_ktrace.c as a result. MFC after: 1 month Revision Changes Path 1.359 +2 -10 src/sys/kern/kern_exec.c 1.337 +1 -31 src/sys/kern/kern_exit.c 1.314 +1 -15 src/sys/kern/kern_fork.c 1.136 +102 -24 src/sys/kern/kern_ktrace.c 1.39 +2 -2 src/sys/sys/ktrace.h