From owner-cvs-src@FreeBSD.ORG Fri Feb 9 23:59:03 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 22CBC16A409 for ; Fri, 9 Feb 2007 23:59:03 +0000 (UTC) (envelope-from zombyfork@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.190]) by mx1.freebsd.org (Postfix) with ESMTP id 936CD13C48E for ; Fri, 9 Feb 2007 23:59:02 +0000 (UTC) (envelope-from zombyfork@gmail.com) Received: by nf-out-0910.google.com with SMTP id m19so1260146nfc for ; Fri, 09 Feb 2007 15:59:01 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:references; b=s2XiLNg5A2vAncqOU0Md9gCqXNWnjo38XwCe6FIvJyCTodmrMsnsc4VjyCeIWSE5zVS2qXYakRn9IZ2Dzuzstr/ExGatZix0stsA5aarmw38DzMSavPf3XMYc1s6xPsAvhWUUP9ftYJhOJl+k1iCBEGqKiDegooBUWMtPG8jbRQ= Received: by 10.82.155.10 with SMTP id c10mr5217615bue.1171065540566; Fri, 09 Feb 2007 15:59:00 -0800 (PST) Received: by 10.49.63.7 with HTTP; Fri, 9 Feb 2007 15:59:00 -0800 (PST) Message-ID: <346a80220702091559o39c68934n5197f34d01d06231@mail.gmail.com> Date: Fri, 9 Feb 2007 16:59:00 -0700 From: "Coleman Kane" To: "Brooks Davis" In-Reply-To: <20070209221913.GA11826@lor.one-eyed-alien.net> MIME-Version: 1.0 References: <200702091903.l19J3Ik5099479@repoman.freebsd.org> <20070209211517.GI1620@funkthat.com> <20070209221913.GA11826@lor.one-eyed-alien.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: cvs-src@freebsd.org, John-Mark Gurney , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/conf GENERIC src/sys/i386/conf GENERIC src/sys/ia64/conf GENERIC src/sys/pc98/conf GENERIC src/sys/powerpc/conf GENERIC src/sys/sparc64/conf GENERIC src/sys/sun4v/conf GENERIC X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: cokane@cokane.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2007 23:59:03 -0000 On 2/9/07, Brooks Davis wrote: > > On Fri, Feb 09, 2007 at 01:15:17PM -0800, John-Mark Gurney wrote: > > Brooks Davis wrote this message on Fri, Feb 09, 2007 at 19:03 +0000: > > > brooks 2007-02-09 19:03:18 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/amd64/conf GENERIC > > > sys/i386/conf GENERIC > > > sys/ia64/conf GENERIC > > > sys/pc98/conf GENERIC > > > sys/powerpc/conf GENERIC > > > sys/sparc64/conf GENERIC > > > sys/sun4v/conf GENERIC > > > Log: > > > Include GEOM_LABEL in GENERIC. It's very useful and not well > publicized > > > enough. > > > > > > Approved by: pjd > > > > Can anyone think of a good place to put a warning about using labels > > along w/ gmirror? I've had a case recently where I was loading g_label, > > but forgot to load g_mirror... Since I was using ufs labels, my fs > > mounted perfectly fine, but was mounting only one part of the g_mirror.. > > I finally found this out when g_label decided to randomly use the other > > disk one boot... > > > > Maybe g_label should not expose duplicate labels? > > That or duplicate lables should be uniquified some how. > > -- Brooks I prefer that last option. Uniquify them somehow, and perhaps spit a warning out to console. "LABEL: ufs/xxxx on device ad4s1b renamed to ufs/xxxx1". Maybe just force it to auto-increment that last number until it finds an available slot. If it can't find an available slot, then spit out an error about ambiguous GEOM labels.... -- Coleman Kane