From owner-freebsd-net@FreeBSD.ORG Mon Aug 6 21:27:26 2012 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 31B1D106566C for ; Mon, 6 Aug 2012 21:27:26 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mail-vb0-f45.google.com (mail-vb0-f45.google.com [209.85.212.45]) by mx1.freebsd.org (Postfix) with ESMTP id D135C8FC08 for ; Mon, 6 Aug 2012 21:27:25 +0000 (UTC) Received: by vbip1 with SMTP id p1so3862754vbi.18 for ; Mon, 06 Aug 2012 14:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=V/XCDgpggjZw0ihQJA3sEWlJroAFps7gOpNWEfLvyiU=; b=UIU/aIAYjnF9gQHkLY4HNJxta5eGExu3oKy23fwOOfpOWxbafsShFetkt+Hq9f9VIJ gfy63EhkUPzreUCgRRc910MwXFfWICqdF46fXZ21NspdBRLkzq2eWJytFGo4MAVYHKVH ychFCB0XYyC2Qqh6cX282LISZf8+3/2NNk3YqOHsax9bfsR7pRNH/HQVvHrAOYNGKFar HS7Nptcpf8XiR+QF9tJZmTa8laWib9OO5KDhzEkD8x9tgICGZ7ihMFc6AAMrqT/vVDIh m1Moq6BGmGr//LDNGpfDEDQVK5H6FFbcAFb66beixkQZhI28PcTTW2koBTaeApvbGK9P +4CA== MIME-Version: 1.0 Received: by 10.58.23.104 with SMTP id l8mr10278597vef.52.1344288096764; Mon, 06 Aug 2012 14:21:36 -0700 (PDT) Received: by 10.58.169.101 with HTTP; Mon, 6 Aug 2012 14:21:36 -0700 (PDT) In-Reply-To: References: Date: Mon, 6 Aug 2012 14:21:36 -0700 Message-ID: From: Jack Vogel To: Andrew Boyer Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-net@freebsd.org Subject: Re: [patch] ixgbe stats cleanup X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Aug 2012 21:27:26 -0000 Looks good to me Andrew, thanks. Jack On Mon, Aug 6, 2012 at 2:00 PM, Andrew Boyer wrote: > This patch fixes some nits in the ixgbe driver statistics: > - Only read FCCRC and FCLAST on 82599+ > - Store total_missed_rx in stats.mpctotal, and display it in a sysctl > - Don't increment if_opackets and if_ipackets every packet; they're > overwritten by hw stats collection > - Increment adapter->dropped_pkts instead of if_ierrors; if_ierrors is > overwritten by hw stats collection > - Include adapter->dropped_pkts in the calculation of if_ierrors > - Increment rxr->packets so that AIM works > > Comments welcome. > > -Andrew > > > > > -------------------------------------------------- > Andrew Boyer aboyer@averesystems.com > > > > > > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >