Date: Mon, 6 Aug 2012 14:21:36 -0700 From: Jack Vogel <jfvogel@gmail.com> To: Andrew Boyer <aboyer@averesystems.com> Cc: freebsd-net@freebsd.org Subject: Re: [patch] ixgbe stats cleanup Message-ID: <CAFOYbcmk%2BD3gh57xbOW63uv9Cm2aYRnqWQoqUReF1P3tSzJajw@mail.gmail.com> In-Reply-To: <C3008412-4F1E-4166-B7FF-1FA5E2F3F53E@averesystems.com> References: <C3008412-4F1E-4166-B7FF-1FA5E2F3F53E@averesystems.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Looks good to me Andrew, thanks. Jack On Mon, Aug 6, 2012 at 2:00 PM, Andrew Boyer <aboyer@averesystems.com>wrote: > This patch fixes some nits in the ixgbe driver statistics: > - Only read FCCRC and FCLAST on 82599+ > - Store total_missed_rx in stats.mpctotal, and display it in a sysctl > - Don't increment if_opackets and if_ipackets every packet; they're > overwritten by hw stats collection > - Increment adapter->dropped_pkts instead of if_ierrors; if_ierrors is > overwritten by hw stats collection > - Include adapter->dropped_pkts in the calculation of if_ierrors > - Increment rxr->packets so that AIM works > > Comments welcome. > > -Andrew > > > > > -------------------------------------------------- > Andrew Boyer aboyer@averesystems.com > > > > > > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFOYbcmk%2BD3gh57xbOW63uv9Cm2aYRnqWQoqUReF1P3tSzJajw>