From owner-freebsd-wireless@FreeBSD.ORG  Mon Jul 29 17:51:51 2013
Return-Path: <owner-freebsd-wireless@FreeBSD.ORG>
Delivered-To: freebsd-wireless@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 7A031C85
 for <freebsd-wireless@freebsd.org>; Mon, 29 Jul 2013 17:51:51 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-wg0-x233.google.com (mail-wg0-x233.google.com
 [IPv6:2a00:1450:400c:c00::233])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 127382569
 for <freebsd-wireless@freebsd.org>; Mon, 29 Jul 2013 17:51:50 +0000 (UTC)
Received: by mail-wg0-f51.google.com with SMTP id a12so1384275wgh.6
 for <freebsd-wireless@freebsd.org>; Mon, 29 Jul 2013 10:51:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=y5vTb+5ACH8w8wmmcVxhkuGDjy/daqzJI3FYzszf/pc=;
 b=dQY/C9RrogLSQH79uJgcjbNYXChJxOJEBwwme+mB2KMA+sPK5DVwHb0JYa3/lIDvJX
 zy98Ddwy/F2QEwBL95F01R8nW+KpNc8pD8cXqD3r0UaHtBL3CAhO/dtFZs29adBfHJ5/
 IbLm7Q+hpN50X4FrjGG8m+I3OlaDLLd00m3fxBRUzf3TaUNanOqtXTbBFYWstA7PdWq5
 Ovmn3fsarO1atH/Y/rWYXrX8m5IQsaujp4bmvNsf6yKk9UgDak6c9BlQthW7P3k+Ol+o
 RIb3pGGqhTlLj07Kog1RNjOQW4FIyZQEtoA7PGboZSNvlf7obRd4SSQJHIXYObYLYiEI
 Fipw==
MIME-Version: 1.0
X-Received: by 10.180.39.212 with SMTP id r20mr8009353wik.30.1375120309312;
 Mon, 29 Jul 2013 10:51:49 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.217.94.132 with HTTP; Mon, 29 Jul 2013 10:51:49 -0700 (PDT)
In-Reply-To: <007601ce8c73$2b508cf0$81f1a6d0$@info>
References: <007601ce8c73$2b508cf0$81f1a6d0$@info>
Date: Mon, 29 Jul 2013 10:51:49 -0700
X-Google-Sender-Auth: HOt31lhQfNACJCsWDknvUT501co
Message-ID: <CAJ-Vmok8s+ZmJonko8m7Vk7h8Bv1=eHfPmCWD2Oq6ybWwJkzxg@mail.gmail.com>
Subject: Re: [iwn] Review split 3
From: Adrian Chadd <adrian@freebsd.org>
To: Cedric GROSS <cg@cgross.info>
Content-Type: text/plain; charset=ISO-8859-1
Cc: freebsd-wireless@freebsd.org
X-BeenThere: freebsd-wireless@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Discussions of 802.11 stack,
 tools device driver development." <freebsd-wireless.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-wireless>, 
 <mailto:freebsd-wireless-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-wireless>
List-Post: <mailto:freebsd-wireless@freebsd.org>
List-Help: <mailto:freebsd-wireless-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
 <mailto:freebsd-wireless-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jul 2013 17:51:51 -0000

Hi!

Cool! ok, the style niggles.

* Your #define IWN_blah needs a TAB between #define and the IWN_blah
value. Right now you have spaces.
* $FreeBSD$ should be after the copyright header, not before
* Your new file is missing the standard single-include stuff.. ie

#ifndef __IF_IWN_DEVID_H__
#define __IF_IWN_DEVID_H__

(header contents go here..)

#endif /* __IF_IWN_DEVID_H__ */



-adrian

On 29 July 2013 08:49, Cedric GROSS <cg@cgross.info> wrote:
> Hello,
>
>
>
> As discuss we Adrian, previous big patch is too heavy for direct application
> in repo.
>
> So I resume splitting modification.
>
>
>
> Here is split 3.
>
> This one create if_iwn_devif.h for storing device ID and subdevice ID for
> later use.
>
> If_iwn.c and If_iwnreg.h modified as needed.
>
>
>
> Cedric
>
>
> _______________________________________________
> freebsd-wireless@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-wireless
> To unsubscribe, send any mail to "freebsd-wireless-unsubscribe@freebsd.org"