From owner-cvs-all@FreeBSD.ORG Mon Mar 17 16:44:38 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D360F106579B; Mon, 17 Mar 2008 16:44:38 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 130778FC1C; Mon, 17 Mar 2008 16:44:37 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8s) with ESMTP id 235801831-1834499 for multiple; Mon, 17 Mar 2008 12:42:37 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m2HGi3qU078981; Mon, 17 Mar 2008 12:44:11 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Andrew Gallatin Date: Mon, 17 Mar 2008 11:57:54 -0400 User-Agent: KMail/1.9.7 References: <200803141941.m2EJfmL2020579@repoman.freebsd.org> <200803170952.42262.jhb@freebsd.org> <18398.33113.488394.494142@grasshopper.cs.duke.edu> In-Reply-To: <18398.33113.488394.494142@grasshopper.cs.duke.edu> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200803171157.54453.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 17 Mar 2008 12:44:11 -0400 (EDT) X-Virus-Scanned: ClamAV 0.91.2/6275/Mon Mar 17 10:08:48 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 intr_machdep.c src/sys/amd64/include intr_machdep.h src/sys/arm/arm intr.c src/sys/i386/i386 intr_machdep.c src/sys/i386/include intr_machdep.h src/sys/ia64/ia64 interrupt.c src/sys/kern kern_intr.c ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Mar 2008 16:44:39 -0000 On Monday 17 March 2008 10:33:38 am Andrew Gallatin wrote: > > John Baldwin writes: > > > > I already have in my tree an amd64/i386-specific sysarch request to bind an > > IRQ to a CPU, but it's sort of a pain to use since we don't expose interrupt > > info to userland very well so the sysadmin can't tell which CPU an IRQ is > > already connected to w/o a verbose dmesg. The first thing I plan to > > implement is the aforementioned bus_bind_intr(9) for device drivers to use. > > More than that, an admin cannot tell what MSI-X vector corresponds to > what functionality. For example, on linux, the driver can attach a > custom label to the irq information seen from cat /proc/irq. Hence my > linux 10GbE driver attaches meaninful labels to each MSI-X vector it > uses. Eg, for 2 "slices" (what we call qsets), we have this on Linux: > > % grep eth0 /proc/interrupts > 510: 0 0 PCI-MSI-edge eth0:slice-1 > 511: 0 5 PCI-MSI-edge eth0:slice-0 > > But on FreeBSD: > > % vmstat -i | grep mxge > irq256: mxge0 318254 74 > irq257: mxge0 311469 73 > > So I'd like the driver to be able to append a custom string > (":slice-%d") to the label used by vmstat -i so the adminstrator > can know what he's binding. Hmm, I've thought about the ability to name MSIs (or at least include the MSI/MSI-X index in the name). Maybe default to index name and let the driver override? -- John Baldwin