From owner-dev-commits-src-all@freebsd.org Wed Jun 23 00:38:36 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7340A665C49; Wed, 23 Jun 2021 00:38:36 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4G8ks72bV3z4lSs; Wed, 23 Jun 2021 00:38:35 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 15N0cQWR073503; Tue, 22 Jun 2021 17:38:26 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 15N0cQBT073502; Tue, 22 Jun 2021 17:38:26 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <202106230038.15N0cQBT073502@gndrsh.dnsmgr.net> Subject: Re: git: e013e36939ac - main - linux(4): Get rid of Linuxulator kernel build options. In-Reply-To: To: Jessica Clarke Date: Tue, 22 Jun 2021 17:38:26 -0700 (PDT) CC: Dmitry Chagin , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4G8ks72bV3z4lSs X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd@gndrsh.dnsmgr.net has no SPF policy when checking 69.59.192.140) smtp.mailfrom=freebsd@gndrsh.dnsmgr.net X-Spamd-Result: default: False [-1.85 / 15.00]; HAS_REPLYTO(0.00)[rgrimes@freebsd.org]; TO_DN_EQ_ADDR_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; ARC_NA(0.00)[]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[5]; SPAMHAUS_ZRD(0.00)[69.59.192.140:from:127.0.2.255]; RCVD_TLS_LAST(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[69.59.192.140:from]; NEURAL_HAM_SHORT(-0.75)[-0.750]; DMARC_NA(0.00)[dnsmgr.net]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[dev-commits-src-all,dev-commits-src-main] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2021 00:38:36 -0000 [ Charset UTF-8 unsupported, converting... ] > On 21 Jun 2021, at 17:56, Dmitry Chagin wrote: > > > > The branch main has been updated by dchagin: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=e013e36939ac87b53195370fb5e29f29c1a4b5c6 > > > > commit e013e36939ac87b53195370fb5e29f29c1a4b5c6 > > Author: Dmitry Chagin > > AuthorDate: 2021-06-22 05:32:39 +0000 > > Commit: Dmitry Chagin > > CommitDate: 2021-06-22 05:32:39 +0000 > > > > linux(4): Get rid of Linuxulator kernel build options. > > > > Stop confusing people, retire COMPAT_LINUX and COMPAT_LINUX32 kernel > > build options. Since we have 32 and 64 bit Linux emulators, we can't build both > > emulators together into the kernel. I don't think it matters, Linux emulation > > depends on loadable modules (via rc). > > > > Cut LINPROCFS and LINSYSFS for consistency. > > I don?t see why these two should be deleted? They currently build fine, > and GNU/kFreeBSD kernels enable them. They might work as modules, but I > would worry that too many parts of userland would try and read them > before /etc/init.d/kldutils (the init script that loads modules) loads > them, so then we?d have to mess around with GRUB configs to preload > them. If the options work, please leave them in. I also see no good reason to remove these options, and it well actually break some of my systems as I do NOT use loadable modules in my deployed systems, and some of them use the LINUXulator. Further anything that can be built as a module should also be supported as a compiled in kernel option, people just expect that to work. > > There?s a separate debate of whether this is the ?right? fix for > COMPAT_LINUX*; arguably that *should* work and it?s a bug that they > don?t, not a feature, even if it?s not of much interest to support? > > I?d like to see the second half reverted, please, and believe the first > should be too, but I feel less strongly about that. > > Jess > > > -- Rod Grimes rgrimes@freebsd.org