From owner-svn-src-all@FreeBSD.ORG Tue Sep 10 11:21:36 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id BD6D746E; Tue, 10 Sep 2013 11:21:36 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 41D222EB2; Tue, 10 Sep 2013 11:21:36 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.7/8.14.7) with ESMTP id r8ABLUqS081787; Tue, 10 Sep 2013 14:21:30 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua r8ABLUqS081787 Received: (from kostik@localhost) by tom.home (8.14.7/8.14.7/Submit) id r8ABLURK081786; Tue, 10 Sep 2013 14:21:30 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 10 Sep 2013 14:21:30 +0300 From: Konstantin Belousov To: John-Mark Gurney Subject: Re: svn commit: r255187 - in head/sys: conf crypto/aesni modules/aesni Message-ID: <20130910112130.GV41229@kib.kiev.ua> References: <201309031831.r83IVNkh026523@svn.freebsd.org> <20130910060132.GA61541@dragon.NUXI.org> <20130910064149.GS68682@funkthat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DeQ9GnsEQp3CI+P2" Content-Disposition: inline In-Reply-To: <20130910064149.GS68682@funkthat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, re@FreeBSD.org, David O'Brien X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Sep 2013 11:21:36 -0000 --DeQ9GnsEQp3CI+P2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 09, 2013 at 11:41:49PM -0700, John-Mark Gurney wrote: > David O'Brien wrote this message on Mon, Sep 09, 2013 at 23:01 -0700: > > On Tue, Sep 03, 2013 at 06:31:23PM +0000, John-Mark Gurney wrote: > > > Log: > > > Use the fact that the AES-NI instructions can be pipelined to impro= ve > > > performance... Use SSE2 instructions for calculating the XTS tweek > > > factor... Let the compiler do more work and handle register alloca= tion > > > by using intrinsics, now only the key schedule is in assembly... > >=20 > > Hi John-Mark, > > Unfortunately this does not work with /usr/bin/gcc (which I still use as > > /usr/bin/cc on this old IBM T60 laptop due to clang's enormous pestimat= ion > > on 'make world' and build times. > >=20 > > Please fix this ASAP or back it out out of 10-CURRENT as it does not wo= rk > > with /usr/bin/gcc: > >=20 > > 1. /usr/bin/gcc cannot handle the "-maes" option. > > I committed r255440 to address this. >=20 > Please back that out until you have an understand of what the real > problem is... I'm sad that the commit was approved w/o bothering to > attempt to figure out the problem... >=20 > > 2. /usr/src/sys/modules/aesni/../../crypto/aesni/aesencdec.h:30:23: err= or: wmmintrin.h: No such file or directory > > and then a cascade of errors follow. >=20 > Sounds like you don't have the latest in-tree gcc... I've been > compiling the AES module w/ the in tree gcc for a while.. This is > w/ the changes in r255185... >=20 > > For now, I've sent a patch to re@ for approval to remove the 'aesni' > > module from the build if not using clang. But the LINT build is > > still broken with /usr/bin/gcc. >=20 > I'll strongly object to this change... Sorry for my mistake, I agree with you. IMO this change should be reverted. >=20 > > > Replace .byte hard coded instructions w/ the proper instructions now > > > that both clang and gcc support them... > >=20 > > Is this out-of-tree latest GCC that supports this? >=20 > Nope, in-tree... Sounds like you haven't installed the latest version > of gcc in tree... >=20 > It could be a problem with a bad interaction w/ delete-old as glebius > added the wmmintrin.h header to the delete-old target in r255354... >=20 > I'll take a closer look at this in the morning, but next time please > attempt to contact the author before taking such actions... >=20 > --=20 > John-Mark Gurney Voice: +1 415 225 5579 >=20 > "All that I will do, has been done, All that I have, has not." --DeQ9GnsEQp3CI+P2 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (FreeBSD) iQIcBAEBAgAGBQJSLwC5AAoJEJDCuSvBvK1BXvEP/RCyrvLik2bM441bbCnihGOk Ky3Uwm5wMClbvhtM0rmbr6dlARdI+LxuqRvVILnDpKpyEM3kgI3SG5lhqEemT87B XYWdrvKd+q1FyBWJYoiwwVaWnJDwuZVvgVdW8sFBIsio19s06Dc2DkPm11Mdpir0 tkQ2z49F20dhN6GgViufh6ImZqxdpND/urIATdxu3fOkAg8zPZshShgwq5Nkwv3b 6OP5iYi7IFyQDM8s5QmaiGT2eIR5irxTI07A2qcc4sJvBHzA7ZV7rmzumeY9mRUH a6MAmpseqf+ShaeZLXA2rxNRQz52Ne4G3tdklyN0JOifhAcoKE7Q2mQNsSVqrYPb NeED0i2LgNIeEarEqfyRrDmjaJyBzbGP1yO4spKzBKfDN6fx/o++tPrc5K6b1xPR W3gUOrBqUAZitEWeficafSsyb6VTN5QC4tm9W7js16j/zF0crEV3ThQ6Scdc6RzY R6M6CjEC+5IB6h/9PatW6U2Y5KHNlIYJOb2a/HXBAqsdQbA+6OyWYBS6ETYCiRgZ 23XABhEM+Pq/GAL2Iqwi6ZxakmzyWY7Rch3zveQkTeovE6dOuj5HN7pYKxLygKoZ +rxQ4LxMTHkMkE6bcWT43IJoZOuGre1+6mGS6v/dFLx+576L86qmmnQaUC0IM1nX ID/Lbding0Mg1FS9l6Mm =xcOe -----END PGP SIGNATURE----- --DeQ9GnsEQp3CI+P2--