From nobody Sun May 5 16:09:53 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VXTyT5NBPz5KCr1; Sun, 05 May 2024 16:09:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VXTyT4czPz41Hq; Sun, 5 May 2024 16:09:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714925393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=spTmkgmUZwjfFJfc2E3yAegqW3uqpH+HcJfEVqfPjNw=; b=lcdGsDjT5/Bg8E60zu5T/7kijTDgYUIoNy6xDrJ88Hwp5DRofkZrZ2EMNkv8iznW2g9kk7 vs3yHN/YWWHPZE/JOT8Q4mM+ScWdPaTGbxG52S86eP1PiCcOTxucWnWi8GsZJdwTFjgiL/ /iHgbtS5MX83i4nyO9bwKWFG8uLeH3RImeAJweUtx7hHcXg2JNyMrHmIvVCkUYCRo64VVM U0cP+Ga1bc0cJW6my/TZNBtVO5aKNvRt7Z55rOzDsRgKm6q6qIAUq/nPr6bguYoHZfgf0i a0F4fQq14Rqq9KoKXSz1Xeqi+7QxcW//vck4Mf+kPBDTBR8NOv06NVrmIfykQw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1714925393; a=rsa-sha256; cv=none; b=D4xtOi2R4h0zqgRp+VZfTyYhSmMi5QDt3nHoI5ljkaaQPkBhuJwWL5/KtCphlzbnnZhJXk 2m9j2PuHlV9l+0WzRMsaUiN0QvpXUf+PY0zFFDSjlfhmm2qmQXXheqFuvzok4H92Q4/o1M zyREbLQZQD50LGgj3SDOUgA9KcxncTX6R9SfFy+vk8VJEQvy2AFFvgCaXAssZ+gpyuiPKb ZyZlqoYgurDMPzyfwlCRoQbtSSqOFdchpJGvsOfTVrlf4UJ1RqmrLESs4/sXSmMYeWkFXh 97bXLfxjIULOmtqrrIrV0FGmBpdrsoUVeeH73DgZk4L28WRBO9d2NV9AypPvnA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714925393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=spTmkgmUZwjfFJfc2E3yAegqW3uqpH+HcJfEVqfPjNw=; b=EdDLN5EH1f2m3SI3RVNJ3PvWf+ktVwcIxvn1vqAYgkKTKN62k+19OTjDvr/sdIyCzkQ2Tw peedZcrmbCImpeRmqEO+r+YsZkk3OR19x24g9clfnw1Icmipia66SnfLlQyiFGjlnD2Ksx 2n7JC7BDbB0D5slQai82aR0wBlQOfmA1wb28p+cZPJbXua09hm+1f2K4xmDRWE7R/6lyGD yyiSKAYDZwH+A7FQmXKUTaDy000aIKuN4zUwpUnDREKtTMBs4nTBiNioaENpg9N4A43d9Z gl3GbG+dGIcK+BOTd3pPLm/9zruTnWeTh6133+ZsIdEHITzGxIDbAp1hfQP0TA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VXTyT40ZjzKYg; Sun, 5 May 2024 16:09:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 445G9rKT065494; Sun, 5 May 2024 16:09:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 445G9rBH065491; Sun, 5 May 2024 16:09:53 GMT (envelope-from git) Date: Sun, 5 May 2024 16:09:53 GMT Message-Id: <202405051609.445G9rBH065491@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Yuri Victorovich Subject: git: 762aa0135a4e - main - Revert "www/chromium: Change default audio output to PULSEAUDIO to make chromium to play nice with desktop environments" List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: yuri X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 762aa0135a4e18d32bd27bba5266fe6edd769d82 Auto-Submitted: auto-generated The branch main has been updated by yuri: URL: https://cgit.FreeBSD.org/ports/commit/?id=762aa0135a4e18d32bd27bba5266fe6edd769d82 commit 762aa0135a4e18d32bd27bba5266fe6edd769d82 Author: Yuri Victorovich AuthorDate: 2024-05-05 15:51:10 +0000 Commit: Yuri Victorovich CommitDate: 2024-05-05 16:09:08 +0000 Revert "www/chromium: Change default audio output to PULSEAUDIO to make chromium to play nice with desktop environments" This reverts commit 89e432ced730385869e5bf6df4b705facbd1c947. Reason: Several people complained that the PulseAudio dependency is a lot heavier than Sndio. This is currently a controversial issue because: 1. PulseAudio is indeed a heavier dependency compared to Sndio, so for people who prefer minimalistic setup Sndio should be a default. 2. Currently desktop environments work best with PulseAudio, so it is better for average users to have PulseAudio as a default backend. It would be best if www/chromium would allow to change audio backend at-startup or on-the-fly without the need to change port options. This can be achieved by the following methods: 1. Flavorizing www/chromium based on audio backends. 2. Creating slave ports with different audio backends. 3. Implementing on-the-fly or at-startup setting of the audio backend. In https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246449#c5 Robert Nagy volunteered to implement audio backend dependency in a proper way. I've suggested that the item 3. above is a proper way for chromium. PR: 246449 --- www/chromium/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/www/chromium/Makefile b/www/chromium/Makefile index 5c289e69d791..9a2a287d8e19 100644 --- a/www/chromium/Makefile +++ b/www/chromium/Makefile @@ -1,6 +1,5 @@ PORTNAME= chromium PORTVERSION= 124.0.6367.118 -PORTREVISION= 1 CATEGORIES= www wayland MASTER_SITES= https://commondatastorage.googleapis.com/chromium-browser-official/ \ https://nerd.hu/distfiles/:external @@ -141,7 +140,7 @@ SUB_FILES= chromium-browser.desktop chrome SUB_LIST+= COMMENT="${COMMENT}" OPTIONS_DEFINE= CODECS CUPS DEBUG DRIVER KERBEROS LTO PIPEWIRE TEST WIDEVINE -OPTIONS_DEFAULT= CODECS CUPS DRIVER KERBEROS PIPEWIRE PULSEAUDIO +OPTIONS_DEFAULT= CODECS CUPS DRIVER KERBEROS PIPEWIRE SNDIO OPTIONS_EXCLUDE_aarch64=LTO OPTIONS_GROUP= AUDIO OPTIONS_GROUP_AUDIO= ALSA PULSEAUDIO SNDIO