Date: Sun, 9 Nov 1997 12:50:01 -0800 (PST) From: Matthew Hunt <mph@pobox.com> To: freebsd-ports Subject: Re: ports/4978: angband port installs user and save dirs with silly permissions Message-ID: <199711092050.MAA03939@hub.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/4978; it has been noted by GNATS.
From: Matthew Hunt <mph@pobox.com>
To: sheldonh@iafrica.com
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: ports/4978: angband port installs user and save dirs with silly permissions
Date: Sun, 9 Nov 1997 15:40:43 -0500
On Sat, Nov 08, 1997 at 02:16:53PM +0200, sheldonh@iafrica.com wrote:
> >Description:
>
> The angband port installs /usr/X11R6/lib/X11/{user,save} with
> world writable permissions. As the game itself is setgid games,
> the dirs only need to be group readable.
I have incorporated Sheldon's patch, which fixes packaging, and made
another modification that makes the install target of the port work
the same way.
Please review and commit ASAP. Thanks.
diff -urN /usr/ports/games/angband/patches/patch-aa angband/patches/patch-aa
--- /usr/ports/games/angband/patches/patch-aa Mon Oct 27 11:16:23 1997
+++ angband/patches/patch-aa Sun Nov 9 15:33:08 1997
@@ -1,5 +1,5 @@
---- Makefile.orig Fri Sep 19 10:55:34 1997
-+++ Makefile Fri Sep 19 10:56:00 1997
+--- Makefile.orig Sun Nov 9 15:27:29 1997
++++ Makefile Sun Nov 9 15:32:43 1997
@@ -0,0 +1,19 @@
+# My makefile for Angband
+# Matthew Hunt <mph@pobox.com>
@@ -12,11 +12,11 @@
+ cd src && make "CFLAGS=$(CFLAGS)"
+
+install: angband
-+ install -c -o bin -g games -m 2755 angband ${PREFIX}/bin/angband
++ install -c -o bin -g games -m 2555 angband ${PREFIX}/bin/angband
+ mkdir -p ${PREFIX}/lib/X11/angband
+ (cd lib && tar cf - * ) | (cd ${PREFIX}/lib/X11/angband && tar xf - )
+ /usr/sbin/chown -R bin.games ${PREFIX}/lib/X11/angband
+ (cd ${PREFIX}/lib/X11/angband && \
-+ /bin/chmod 775 apex bone data edit file help info xtra && \
-+ /bin/chmod 1777 save user )
++ /bin/chmod 775 apex bone data edit file help info xtra\
++ save user )
+ install -o games -g games -m 664 /dev/null ${PREFIX}/lib/X11/angband/apex/scores.raw
diff -urN /usr/ports/games/angband/pkg/PLIST angband/pkg/PLIST
--- /usr/ports/games/angband/pkg/PLIST Mon Oct 27 11:16:23 1997
+++ angband/pkg/PLIST Sun Nov 9 15:26:53 1997
@@ -66,8 +66,8 @@
@exec chmod 775 %D/lib/X11/angband/help
@exec chmod 775 %D/lib/X11/angband/info
@exec chmod 775 %D/lib/X11/angband/xtra
-@exec chmod 1777 %D/lib/X11/angband/save
-@exec chmod 1777 %D/lib/X11/angband/user
+@exec chmod 775 %D/lib/X11/angband/save
+@exec chmod 775 %D/lib/X11/angband/user
@exec chmod 664 %D/lib/X11/angband/apex/scores.raw
@dirrm lib/X11/angband/bone
@dirrm lib/X11/angband/data
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199711092050.MAA03939>