From owner-svn-ports-all@freebsd.org Sun Feb 14 17:38:48 2021 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D9E6E536C28; Sun, 14 Feb 2021 17:38:48 +0000 (UTC) (envelope-from bacon4000@gmail.com) Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ddvbr5ZrGz3r1t; Sun, 14 Feb 2021 17:38:48 +0000 (UTC) (envelope-from bacon4000@gmail.com) Received: by mail-qk1-x72f.google.com with SMTP id t62so4561197qke.7; Sun, 14 Feb 2021 09:38:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=dWxoMw4uKafcuKYdd/AAPH9Zzofqy5IIn7HQb9r8nsU=; b=M09Q8giHQBF/+Sa3PhSOnxJViWHhRTRVkT0NltOmbOtj3GA3LkmUfsleFxsAUaah5H DnY+MXTayKiSjPs6U8/ZxiKQYRvHH1tmPQYqUXYSuHUKPONDAvP4+AOZgEXm3+V+V1HC 26xH49pZ+hqzwRR8lML9PPuJsMPwd1EPrDdIoYERASZMW8FeFS4jOM8151BUDyYX83BK tG45NFeT9WmTAGeNn3o8wUNj903cPxEUYhrPIe43Nib2Kfkj/H1rWzFJyI711o6uWZYi q/i8QkfprP1wKaIh4dSwvKqXy8nEB5tYcYD5SsAB3ngq3eKzHiWmY1vXq8lg8CTFDti7 nA4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=dWxoMw4uKafcuKYdd/AAPH9Zzofqy5IIn7HQb9r8nsU=; b=BlxR5Q1bPckJkhcEdYdTrbjpIpYrvElQuXOA8b9rlUZ+oLtioHgHxBAkspIzsj4pw8 rrwyxU1yHkf26Y9AzQHceD69XDfY7e43ABtdRaJ1kpWySSsoImFZgWLGNQ0rKHHPksPi tVVvbKnxTBNOeB8Ym0N4UCCUa9vKMrE0yw4Of8TKvOT/INNGoxai/mmqvNaSxEpj7I/r CQxvQdUuFShq++qlaSR3OmRciHnR45sSgo8WqGCvBla3VwgiM1FsCZJNfAiJ5hhEspeD kEBEwUJ7SZBNru8kvO+hilc8pmzaWN3KxV6jlUfig94qoYgLL95+OH6pe1hH2P9eagYQ qgfg== X-Gm-Message-State: AOAM531ENUzMPOprId84Io/gERFTRElenuDb02KbVJGpiBMXgSlQjn99 4Tad5Tey8ZDUCtgQ1xaBB1rHmD6akNzrEQ== X-Google-Smtp-Source: ABdhPJwTbNVQ7ksQyNkiWhArjbfH12oArwm86587Ff8UAZNlUlthYY9UWE/fUSmjNyo6Bg2YQGDmuA== X-Received: by 2002:a37:7143:: with SMTP id m64mr11728212qkc.271.1613324326115; Sun, 14 Feb 2021 09:38:46 -0800 (PST) Received: from coral.acadix.biz (2603-6000-a401-3a00-0223-24ff-fe37-c4d7.res6.spectrum.com. [2603:6000:a401:3a00:223:24ff:fe37:c4d7]) by smtp.gmail.com with ESMTPSA id y35sm9498245qtd.10.2021.02.14.09.38.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Feb 2021 09:38:45 -0800 (PST) Subject: Re: svn commit: r565224 - in head/lang/pocl: . files To: Christoph Moench-Tegeder , "Jason W. Bacon" Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <202102141304.11ED4BTl046406@repo.freebsd.org> From: Jason Bacon Message-ID: Date: Sun, 14 Feb 2021 11:38:24 -0600 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Rspamd-Queue-Id: 4Ddvbr5ZrGz3r1t X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Feb 2021 17:38:48 -0000 On 2/14/21 7:40 AM, Christoph Moench-Tegeder wrote: > ## Jason W. Bacon (jwb@FreeBSD.org): > >> New Revision: 565224 >> URL: https://svnweb.freebsd.org/changeset/ports/565224 >> >> Log: >> lang/pocl: Update hwloc dependency to hwloc2 > The intention is great, but the execution... has problems. > >> -PORTNAME=3D pocl >> +PORTNAME=3D pocl > First, while I'm all in favor of consistent white space, mixing this > with the stated (per commit message) change makes the diff harder > to read and "svn annotate" (and similar tools) harder to use later on. Are you suggesting that whitespace changes should be done in a separate=20 commit? > >> BUILD_DEPENDS=3D llvm${LLVM_VERSION}>=3D0:devel/llvm${LLVM_VERSION} = \ >> - opencl>=3D2.2:devel/opencl >> -LIB_DEPENDS=3D libhwloc.so:devel/hwloc \ >> - libOpenCL.so:devel/ocl-icd >> -RUN_DEPENDS=3D ${BUILD_DEPENDS} >> + opencl>=3D2.2:devel/opencl >> +LIB_DEPENDS=3D libhwloc.so.15:devel/hwloc2 libOpenCL.so:devel/ocl-icd= >> +RUN_DEPENDS=3D libhwloc.so.15:devel/hwloc2 libOpenCL.so:devel/ocl-icd= > And this is plain wrong. libhwloc.so.15 and libOpenCL.so are not > "executables or files this port depends on" - they're libraries and > belong into LIB_DEPENDS only. At the same time, you dropped that > llvm from RUN_DEPENDS - now that I look at it closely, I have a hunch > that the previous "RUN_DEPENDS=3D ${BUILD_DEPENDS}" wasn't right either= > (would this really need sphinx, cmake and ninja as RUN_DEPENDS?), > but none of that is even mentioned in the commit message and I > cannot tell if this was intentional or an accident. > > Anyways, the build bombs out in run-depends "pocl-1.6 depends on > executable: libhwloc.so.15 - not found", which is why I looked at this > in the first place. > Oy...=C2=A0 Not feeling well today but have to push through the pile on m= y=20 desk.=C2=A0 This was some sort of mishap copying the changes after poudri= ere=20 testing elsewhere.=C2=A0 I'll just reverse the RUN_DEPENDS change for now= =2E=C2=A0=20 This port needs more work I'm in no shape to do today. Thanks for the heads-up, =C2=A0=C2=A0=C2=A0 JB --=20 Earth is a beta site.