From owner-freebsd-ports@FreeBSD.ORG Sun Nov 15 20:48:24 2009 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 92B86106566C for ; Sun, 15 Nov 2009 20:48:24 +0000 (UTC) (envelope-from peterjeremy@acm.org) Received: from mail13.syd.optusnet.com.au (mail13.syd.optusnet.com.au [211.29.132.194]) by mx1.freebsd.org (Postfix) with ESMTP id 1E45C8FC1A for ; Sun, 15 Nov 2009 20:48:23 +0000 (UTC) Received: from server.vk2pj.dyndns.org (c122-106-232-83.belrs3.nsw.optusnet.com.au [122.106.232.83]) by mail13.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id nAFKmKnu025011 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 16 Nov 2009 07:48:21 +1100 X-Bogosity: Ham, spamicity=0.000000 Received: from server.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by server.vk2pj.dyndns.org (8.14.3/8.14.3) with ESMTP id nAFKmJvd058463; Mon, 16 Nov 2009 07:48:19 +1100 (EST) (envelope-from peter@server.vk2pj.dyndns.org) Received: (from peter@localhost) by server.vk2pj.dyndns.org (8.14.3/8.14.3/Submit) id nAFKmJBo058462; Mon, 16 Nov 2009 07:48:19 +1100 (EST) (envelope-from peter) Date: Mon, 16 Nov 2009 07:48:18 +1100 From: Peter Jeremy To: Thomas Sandford Message-ID: <20091115204818.GA57571@server.vk2pj.dyndns.org> References: <4AF897A4.3070408@delphij.net> <20091109225232.GA34294@lor.one-eyed-alien.net> <4AF9B6CC.5090308@delphij.net> <20091113011000.GA45256@atarininja.org> <20091113200607.GA59749@atarininja.org> <4AFED0D3.2050403@paradisegreen.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="k+w/mQv8wyuph6w0" Content-Disposition: inline In-Reply-To: <4AFED0D3.2050403@paradisegreen.co.uk> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.20 (2009-06-14) Cc: ports@freebsd.org Subject: Re: RFC: svn for make fetch X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Nov 2009 20:48:24 -0000 --k+w/mQv8wyuph6w0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2009-Nov-14 15:46:27 +0000, Thomas Sandford wrote: >Wesley Shields wrote: >> Sure, but it doesn't belong in bsd.*.mk. Turn it into a script and >> submit it as a regular port. > >If it were just one port and/or just a port maintainers tool I'd agree.=20 >But this is something that affects MULTIPLE ports. Based on your numbers, 15 ports - less that 0.1% of the ports tree. >Surely the whole value/purpose of the ports build infrastructure is to=20 >present a consistent way of doing things rather than different=20 >maintainers doing their own thing and solving problems in different, and= =20 >quite possibly sub-optimal ways and/or bloating multiple individual port= =20 >Makefiles with what could be kept in a single bsd.*.mk file. If it affected several hundred ports and/or was visible to the end user then this might be justification for embedding it into bsd.*.mk. The ports build infrastructure is already quite large (>20K LOC) and difficult to follow. The overheads associated with loading bsd.*.mk files also makes operations like "make index" very time-consuming. IMHO, bloating it further to marginally simplify life for the maintainers of ~15 ports is not a good tradeoff. Wesley's suggestion above sounds like the best solution. >And if the file were (say) bsd.vcs.mk and were pulled in only if one of > >USE_SVNFETCH >USE_CVSFETCH >USE_GITFETCH > >etc were defined then the impact of the bloat on other ports is minimal. If you still want to go this way, I'd suggest writing a stand-alone bsd.vcs.mk that can be .include'd by the port when it needs the functionality. --=20 Peter Jeremy --k+w/mQv8wyuph6w0 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.13 (FreeBSD) iEYEARECAAYFAksAaRIACgkQ/opHv/APuIctcgCfZSGUSr/4sTc4Axks3wIkbUQa d5wAoIIRzCTsZjCKsphBMGxrl0u6BpIj =hBX/ -----END PGP SIGNATURE----- --k+w/mQv8wyuph6w0--