From owner-freebsd-current@FreeBSD.ORG Fri Aug 1 22:56:22 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 39C9FEE0; Fri, 1 Aug 2014 22:56:22 +0000 (UTC) Received: from mail.fer.hr (mail.fer.hr [161.53.72.233]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.fer.hr", Issuer "TERENA SSL CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 950DA2437; Fri, 1 Aug 2014 22:56:20 +0000 (UTC) Received: from x23 (31.147.14.167) by MAIL.fer.hr (161.53.72.233) with Microsoft SMTP Server (TLS) id 14.2.342.3; Sat, 2 Aug 2014 00:55:02 +0200 Date: Sat, 2 Aug 2014 00:55:20 +0200 From: Marko Zec To: Adrian Chadd Subject: Re: domain_add(xxx) after domainfinalize... Message-ID: <20140802005520.29ca841b@x23> In-Reply-To: References: <20140801193403.GE50495@funkthat.com> <20140801222118.GH50495@funkthat.com> Organization: FER X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.19; amd64-portbld-freebsd9.1) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [31.147.14.167] Cc: freebsd-current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Aug 2014 22:56:22 -0000 On Fri, 1 Aug 2014 15:42:30 -0700 Adrian Chadd wrote: > I'd just make it a panic. :) Are you prepared to say goodbye to kldloading netgraph at runtime? Marko > > -a > > > On 1 August 2014 15:21, John-Mark Gurney wrote: > > Svatopluk Kraus wrote this message on Sat, Aug 02, 2014 at 00:05 > > +0200: > >> Just what I've got in January 2011: > >> http://lists.freebsd.org/pipermail/freebsd-hackers/2011-January/034037.html > > > > Sadly, after three (or six+) years, it is clear that these bugs will > > not be fixed, and this warning message is not useful, since no one > > has stepped up to fix them.. > > > > btw, you might want to create a bug w/ the information you tracked > > down to hopefully help the person that decides to finally fix them, > > though I doubt they will ever be fixed as people apparently don't > > see bad behavior... > > > > Unless someone fixes the bugs in the next few days, I will commit > > the following patch: > > Index: uipc_domain.c > > =================================================================== > > --- uipc_domain.c (revision 266964) > > +++ uipc_domain.c (working copy) > > @@ -227,15 +227,10 @@ > > printf("WARNING: attempt to domain_add(%s) before " > > "domaininit()\n", dp->dom_name); > > #endif > > -#ifdef notyet > > - KASSERT(domain_init_status < 2, > > - ("attempt to domain_add(%s) after domainfinalize()", > > - dp->dom_name)); > > -#else > > - if (domain_init_status >= 2) > > - printf("WARNING: attempt to domain_add(%s) after " > > - "domainfinalize()\n", dp->dom_name); > > -#endif > > + /* > > + * XXX - there are bugs WRT to adding domain after > > domain_finalize is > > + * called > > + */ > > mtx_unlock(&dom_mtx); > > } > > > > > >> On Fri, Aug 1, 2014 at 9:34 PM, John-Mark Gurney > >> wrote: > >> > >> > So, I have a laptop that devd loads the bluetooth module every > >> > time.. > >> > > >> > This means I get the following error on every boot: > >> > WARNING: attempt to domain_add(bluetooth) after domainfinalize() > >> > WARNING: attempt to domain_add(netgraph) after domainfinalize() > >> > > >> > Is there any real benefit to this warning? I just looked at the > >> > code, and the domain gets added despite the warning... > >> > > >> > Also, it looks like the pervious warning, we should just make > >> > that an if/panic since it's clearly a programming bug, or kill > >> > the ifndef INVARIANTS... > > > > -- > > John-Mark Gurney Voice: +1 415 225 > > 5579 > > > > "All that I will do, has been done, All that I have, has not." > > _______________________________________________ > > freebsd-current@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to > > "freebsd-current-unsubscribe@freebsd.org" > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to > "freebsd-current-unsubscribe@freebsd.org"