From owner-svn-src-all@freebsd.org Mon Aug 26 17:25:55 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7487AE108B; Mon, 26 Aug 2019 17:25:55 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46HJnH2HJsz3Cgv; Mon, 26 Aug 2019 17:25:54 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f45.google.com with SMTP id 18so39129413ioe.10; Mon, 26 Aug 2019 10:25:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=0kZl83pA3Hq31XlGvGPzmDs7uT+aEXK/JLr0t4jKFj4=; b=RlbC+MFQzJw8fjAemvjLqBVZpTWXdNC4J3oAYHnKc+JPIe2Elu5+hOLiEyd8xeHG9t DJmB+GOHFAsxUCEkYPE0N89mRcUk7x8roT+SaO6vLgGgPER1I2ustJbnaKuGIo69MCgD A5Oyyf11TYs20fHOf73RtIEofVQRwN+saDYIwRcsKzrcqyUHngspX/Kn3u/0iipjqTcR rnX+Z3+UPEqE24EOsTMLl2SYm1rb6kASIiePTOrd77T5i9D6URBCssXck1M5qGBJVNv5 rpeJ00vEXVCerjY1OcV4AumC45vFKB1smau+r917B7DWfzU+/TQXOTaP7L6crZQn+n5D PW9g== X-Gm-Message-State: APjAAAUtgfQdaLA+kkiuGf3shHseUgToI3D5JQefrynsj82NS8+TpvjY q3/gE+9MZcVP4GJqSTCCphIu/pfW X-Google-Smtp-Source: APXvYqxdnLAKKmpSAOBIB/Jpnd3AU0wtNXGpHDMwQ480PaBysmC5hJ6pqYvw/cC8Ja/qAK3R+w2jfw== X-Received: by 2002:a6b:3784:: with SMTP id e126mr21075691ioa.8.1566840353148; Mon, 26 Aug 2019 10:25:53 -0700 (PDT) Received: from mail-io1-f43.google.com (mail-io1-f43.google.com. [209.85.166.43]) by smtp.gmail.com with ESMTPSA id y17sm10088442ioa.52.2019.08.26.10.25.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2019 10:25:52 -0700 (PDT) Received: by mail-io1-f43.google.com with SMTP id j4so30833363iog.11; Mon, 26 Aug 2019 10:25:52 -0700 (PDT) X-Received: by 2002:a6b:e013:: with SMTP id z19mr660569iog.141.1566840352555; Mon, 26 Aug 2019 10:25:52 -0700 (PDT) MIME-Version: 1.0 References: <201908241528.x7OFSemm026182@repo.freebsd.org> <20190824161503.GA71821@kib.kiev.ua> <20190824204353.GH71821@kib.kiev.ua> <1a09a4ef-45aa-1bb2-5b16-1bde24df0f3d@FreeBSD.org> In-Reply-To: <1a09a4ef-45aa-1bb2-5b16-1bde24df0f3d@FreeBSD.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Mon, 26 Aug 2019 10:25:41 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r351456 - head/sys/amd64/amd64 To: John Baldwin Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46HJnH2HJsz3Cgv X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.977,0]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Aug 2019 17:25:55 -0000 r351456 only loosened restrictions on some of the less common thread types; it was accidentally necessary, but not sufficient. 351494, 351495, and 351496 (at least) are also necessary, once the issue was identified. Best, Conrad On Mon, Aug 26, 2019 at 9:25 AM John Baldwin wrote: > > On 8/24/19 1:43 PM, Konstantin Belousov wrote: > > On Sat, Aug 24, 2019 at 11:47:52AM -0700, Conrad Meyer wrote: > >> On Sat, Aug 24, 2019 at 9:15 AM Konstantin Belousov wrote: > >>> > >>> On Sat, Aug 24, 2019 at 08:49:42AM -0700, Conrad Meyer wrote: > >>>> Hi Konstantin, > >>>> > >>>> What is the motivation for this change? The commit message doesn't > >>>> really describe why it was done. > >>> > >>> Really it does. There is no point to request allocations for e.g. > >>> doublefault stack to be at the local domain, because this stack is only > >>> used once. Doublefault is definitely a machine halt situation, it does > >>> not matter if it generates inter-socket traffic to handle. > >>> > >>> Same for boot stacks, and for mce. > >>> > >>> The change avoids unnecessary constraints. > >> > >> Sure, but what is the harm of the unnecessary constraints? Does this > >> change fix an actual bug, or is it just a stylistic preference to > >> avoid domain-specific allocations for infrequently used objects? > > I am not sure about this being a stylistic preference. We usually > > write code to express the required actions. I removed constraints > > which did not added anything neither to code correctness nor to the > > performance. > > Judging by the thread on current though, this fixes boot panics on > machines with NUMA but CPUs that don't have local memory, correct? > I think that's the thing Conrad is asking. > > -- > John Baldwin