From owner-svn-src-head@FreeBSD.ORG Tue Nov 6 23:02:14 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3CDDF145; Tue, 6 Nov 2012 23:02:14 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id AF5808FC0C; Tue, 6 Nov 2012 23:02:13 +0000 (UTC) Received: from tom.home (localhost [127.0.0.1]) by kib.kiev.ua (8.14.5/8.14.5) with ESMTP id qA6N215W071421; Wed, 7 Nov 2012 01:02:01 +0200 (EET) (envelope-from kostikbel@gmail.com) X-DKIM: OpenDKIM Filter v2.5.2 kib.kiev.ua qA6N215W071421 Received: (from kostik@localhost) by tom.home (8.14.5/8.14.5/Submit) id qA6N21Pt071420; Wed, 7 Nov 2012 01:02:01 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 7 Nov 2012 01:02:01 +0200 From: Konstantin Belousov To: Ben Kaduk Subject: Re: svn commit: r241896 - in head: . cddl/contrib/opensolaris/lib/libzpool/common/sys share/man/man9 sys/cam/ctl sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/openso... Message-ID: <20121106230201.GN73505@kib.kiev.ua> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="eVN8q1r3v0Uw6/qa" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=0.2 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2012 23:02:14 -0000 --eVN8q1r3v0Uw6/qa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 06, 2012 at 05:50:43PM -0500, Ben Kaduk wrote: > On Mon, Oct 22, 2012 at 1:50 PM, Konstantin Belousov wr= ote: > > Author: kib > > Date: Mon Oct 22 17:50:54 2012 > > New Revision: 241896 > > URL: http://svn.freebsd.org/changeset/base/241896 > > > > Log: > > Remove the support for using non-mpsafe filesystem modules. > > > > In particular, do not lock Giant conditionally when calling into the > > filesystem module, remove the VFS_LOCK_GIANT() and related > > macros. Stop handling buffers belonging to non-mpsafe filesystems. > > > > The VFS_VERSION is bumped to indicate the interface change which does > > not result in the interface signatures changes. > > > > Conducted and reviewed by: attilio > > Tested by: pho > > >=20 > Sorry for late reply. >=20 > % --- head/sys/sys/namei.h 2011/12/29 12:28:05 228952 > % +++ head/sys/sys/namei.h 2012/10/22 17:50:54 241896 > % @@ -144,15 +144,11 @@ > % #define ISOPEN 0x00200000 /* caller is opening; return a real vnode. = */ > % #define NOCROSSMOUNT 0x00400000 /* do not cross mount points */ > % #define NOMACCHECK 0x00800000 /* do not perform MAC checks */ > % -#define MPSAFE 0x01000000 /* namei() must acquire Giant if needed. */ >=20 > It seems that removing the definition of MPSAFE causes out-of-tree > filesystem modules to not build. > Perhaps a definition can remain for some period to allow a smoother trans= ition? No, it shall not be left or restored, since its functionality is removed. > Conditional on __FreeBSD_Version is the proper fix, of course, but > takes longer to get everywhere. --eVN8q1r3v0Uw6/qa Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlCZlukACgkQC3+MBN1Mb4gj8wCgheQ4WQkMvoU3aoFU/4kGZqjj ap0AoIpozcNUlUgeuHvhHVlY8VY8TjEP =wQm4 -----END PGP SIGNATURE----- --eVN8q1r3v0Uw6/qa--