From owner-freebsd-bugs@freebsd.org Fri Oct 5 09:47:44 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7FF2B10C800F for ; Fri, 5 Oct 2018 09:47:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 1CF6979C52 for ; Fri, 5 Oct 2018 09:47:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id D57EB10C800D; Fri, 5 Oct 2018 09:47:43 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B395D10C800B for ; Fri, 5 Oct 2018 09:47:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3CB1A79C43 for ; Fri, 5 Oct 2018 09:47:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 62DB71E87D for ; Fri, 5 Oct 2018 09:47:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w959lgdu021290 for ; Fri, 5 Oct 2018 09:47:42 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w959lgEU021289 for bugs@FreeBSD.org; Fri, 5 Oct 2018 09:47:42 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 230561] ntpd error: only one pidfile option allowed Date: Fri, 05 Oct 2018 09:47:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ian@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc bug_status resolution assigned_to see_also Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2018 09:47:44 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230561 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koobs@FreeBSD.org Status|Closed |Open Resolution|Not A Bug |--- Assignee|bugs@FreeBSD.org |ian@FreeBSD.org See Also| |https://bugs.freebsd.org/bu | |gzilla/show_bug.cgi?id=3D1= 135 | |52, | |https://bugs.freebsd.org/bu | |gzilla/show_bug.cgi?id=3D2= 315 | |92 --- Comment #4 from Kubilay Kocak --- Hi Ian, I'm commenting here as I've only just realised my CURRENT system's ntpd was= not running (for a while it seems!), discovering the reported error when trying= to start the service manually.=20 I'm not sure why/how I didn't pick the issue up earlier, perhaps it was mis= sed in daily periodic logs. I'm a fairly seasoned FreeBSD user and I worry about the user experience of this issue for those less experienced. There is a section (can_run_root() function) in the startup script which ch= ecks for user-supplied arguments (including pidfile), which when set, causes the scripts default behaviour (to use user:ntp and its own arguments/locations)= to not be used, *but* apparently (?) only for the driftfile argument # Otherwise, figure out what to do about the driftfile option. If set # by the admin, we don't add the option. driftopt=3D"" # admin set the option, we don't need to add it. Why can't the same, if not specific, then general behaviour, apply to !driftfile arguments as well? Why is pidfile a/the special case? If its a permission issue, why isn't tha= t a problem for driftfile, keyfile, etc? Isn't the actual and only issue that the only argument the script explicitly sets is "-p ${pidfile}" causing the conflict/error reported here, but not f= or any other arguments? If the pidfile argument absolutely and positively cannot be supported in any capacity, differently from other path/file-value arguments, pidfile should = be stripped from arguments, given the *only* outcome of the user supplying it = is this error. In addition, and note I am not advocating that rc scripts should support an= y or all *particular values* for command arguments (see bug 231592), but not supporting overriding arguments via foo_flags via rc.conf is a pola violati= on and inconsistent (I believe) with; the expectations of our users generally,= and almost all other rc scripts we ship (in base and ports). @with bugmeister hat, assign to Ian as previous issue closer and committer = of base r336547 --=20 You are receiving this mail because: You are the assignee for the bug.=