From owner-svn-src-head@freebsd.org Mon Jun 22 22:07:57 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2ACC633DF7F; Mon, 22 Jun 2020 22:07:57 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49rNnn0KwKz4VFX; Mon, 22 Jun 2020 22:07:56 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qv1-xf42.google.com with SMTP id e2so8746303qvw.7; Mon, 22 Jun 2020 15:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3zgR0foZxLwVYUleASJIE3YTbNtAIpnYav3NrnIervE=; b=Q2ybW/TXZz3E8AQGgjJj4LcZV6cTRiOHEAKDxTqWos1ngdnM+jnhqQFOgshFJMfdxU QtrutJ+LL4SNbFMcBrlW/H8Taya8fAKyU53tCTIOvEaVBuQKyPJuebIrgs8gCMDx6xEF BDrlA+DaFY8Tz7JFURDOAsty0z7GN4m9UhpIO4047qBZymNhYvZ/tCzDCxHzkfQgMZNH 9Y49fH4tgBeq2yWKT9cGiE8Nib1Gjo/ceknsSxI7IIbh1XFeM1G2m/PfKhnZG6yROSN+ fPNouiFdcUCkWzNc+Z2STX+BZiGtDBo/5Sc5KYgMkq4rnJdXIrGAovs8bqbdmLJm/cRm /Yeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=3zgR0foZxLwVYUleASJIE3YTbNtAIpnYav3NrnIervE=; b=AB4cJzkUYmBumrrDCMBUn4KIVcVXcw7uUXRyXmPW8294cr2EtT9MLqh8XxvVslXUgd sl2+/MKP9RFpSRNXC2VzvJEZRUWmygFmrLrk2uyT6lG7ax9KXI2VbY3GcJtpdxxjLDIy kz1GCKbwuOtlYyU3tYuB1y+uMXrHlDe29NjM/Z4GJgL2H++HkzorTij6qlfdluJt6u05 nH5YNEzQf1a2FDX5acz1AWq2hQZbKQZaDAijPDo257kvqvAnRQEVCyO/5OaLKYxHy11B EUCfnpNwGcRXH/X86GW9cdYLPL2xgkQnDVilSD5nd1bbK8Ul+F/pjPsK0AEu25UBlru+ i14A== X-Gm-Message-State: AOAM531R1pOpXunEMy+JTblREnd4tVRrMENy0v7h8fhSfvA0NZyA3S9T MQ2wDaQNg9gnapZlYy4i8n65r1RVo4k= X-Google-Smtp-Source: ABdhPJxQKchJiItyDjUIoskjcOymybK+edgu/SU/OefcUHQDvp59UXUNP9irFIBvkdSpJlrdNiXsEQ== X-Received: by 2002:a05:6214:1543:: with SMTP id t3mr9713168qvw.89.1592863676111; Mon, 22 Jun 2020 15:07:56 -0700 (PDT) Received: from raichu (bras-base-toroon0560w-grc-20-184-147-206-12.dsl.bell.ca. [184.147.206.12]) by smtp.gmail.com with ESMTPSA id q47sm751771qta.16.2020.06.22.15.07.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2020 15:07:54 -0700 (PDT) Sender: Mark Johnston Date: Mon, 22 Jun 2020 18:07:52 -0400 From: Mark Johnston To: John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r362338 - in head: share/man/man4 sys/conf sys/kern sys/netinet sys/netinet6 sys/netipsec sys/netpfil/pf Message-ID: <20200622220752.GB51374@raichu> References: <202006181932.05IJWZYH009560@repo.freebsd.org> <20200622011035.GG85944@raichu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 49rNnn0KwKz4VFX X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2020 22:07:57 -0000 On Mon, Jun 22, 2020 at 11:35:38AM -0700, John Baldwin wrote: > On 6/21/20 6:10 PM, Mark Johnston wrote: > > On Fri, Jun 19, 2020 at 08:33:35AM -0700, John Baldwin wrote: > >> On 6/18/20 12:32 PM, Mark Johnston wrote: > >>> Author: markj > >>> Date: Thu Jun 18 19:32:34 2020 > >>> New Revision: 362338 > >>> URL: https://svnweb.freebsd.org/changeset/base/362338 > >>> > >>> Log: > >>> Add the SCTP_SUPPORT kernel option. > >>> > >>> This is in preparation for enabling a loadable SCTP stack. Analogous to > >>> IPSEC/IPSEC_SUPPORT, the SCTP_SUPPORT kernel option must be configured > >>> in order to support a loadable SCTP implementation. > >>> > >>> Discussed with: tuexen > >>> MFC after: 2 weeks > >>> Sponsored by: The FreeBSD Foundation > >> > >> Do you want to add similar handling to sys/conf/config.mk that we have > >> for IPsec? Also, do we want to avoid building sctp.ko if it is in the > >> kernel like we do for ipsec.ko and/or only build it if the kernel contains > >> SCTP_SUPPORT? (For ipsec.ko we had to do that as it wouldn't compile, not > >> sure if the same is true for sctp.ko) > > > > Sorry for the delay. > > I think we do indeed want similar handling in config.mk, I will work on > > it. It is probably also reasonable to avoid compiling sctp.ko when > > SCTP_SUPPORT is not defined, though I can't see a reason that wouldn't > > work today since SCTP_SUPPORT is not used in any headers. > > Ok. ipsec.ko mattered more when the build broke. Whether or not we compile > "duplicate" modules for kernels is perhaps a larger question. I think I > might favor that change, but it is a larger change that merits some thought. > In particular, you want good code coverage for things like LINT builds, so > maybe we really should still compile modules whenever possible. I tend to assume that a buildkernel of GENERIC without any special flags will always build all modules (except those not available for the target platform of course), so I was a bit surprised to see that this isn't the case for ipsec.ko. As Rodney pointed out it provides marginally better coverage against build breaks. If you think we can restore the old behaviour for ipsec without too much work I think it'd be reasonable to change that and compile sctp.ko even when "options SCTP" is configured. I can't spot any similar cases in sys/modules/Makefile with a bit of skimming.