From nobody Tue Sep 23 18:30:59 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cWT7m0bShz67kst; Tue, 23 Sep 2025 18:31:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cWT7l5whtz3LcT; Tue, 23 Sep 2025 18:30:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758652259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+2nU8u/UOLS80ka7ih32Tpfjv1KdyNtEEEYpkbjibeQ=; b=mCPBa1Molvehr25Z9fGE9g6XT4HkaZeoWaRSck8tQHP0+uOSb1t9F+lx+2sJlDKuwPDOww Kh7LVp7pJCoRBmeNQKNU9TR4wwQL17I7EfR3pcmk/2xM2hds3dgA9x37lEN7qxovummNCg wb9mTPPH0Sm/v+6fNdPjRoCxGlpnU6xrUyw0YEUBYQbv44PeblusJsKstzlaWqB8lntqpw 0dZlAXchy4HIJyQ+4ZqWPmqDkF0BEQiaP/74Y2J4TYolJVyVMxyZ6fUk68iXoSAjQkdZu5 Y8R7LYDZqXzwBxiayXK5LjKw/ryAUusle2eOUQXXWDsLDMYR+a87g/WyUcJMrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758652259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+2nU8u/UOLS80ka7ih32Tpfjv1KdyNtEEEYpkbjibeQ=; b=abErv1AaycJ0DS0Yh7S+w8JM7U2M8AM8It/+/NsfFgbv0cxEXh/O2McYf1ZTyI9x6OK8Vl f/73a7hEMGMMuRSLSoMrVvqFvowSCqp547a6cqwmyGEoHS2iRVqiCPTE1M/vX9Jvn9esVI OHEfvvkAC4srz1E79KMj6dR5bczIfVFiMIjYL5zLuS0EmQ1DUjMl9l3mdQdX9YP1HBiZuV kpxSqxAQuynKHFTeLYbBwUQKV15b1JZfSodUdx3tapufGpN7pGSsn0FS32jo9DWWshmAPk A/9r/8ESblFcbcZLLrtJ0F+x0fEyO4AIfyp5iGCaSz+tRT/MhCnaf0DZ4g3ocA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758652259; a=rsa-sha256; cv=none; b=dR7vlCZuPUQkVdIMp+tB2d44XzENLaB9QkFOFhOc6lZG8Dc9blU2XI262tBHgbsaLA7JCy 7FVgNwoVM/Y5+m5XVvkIK/AdUOtPcZwOsa+PZV4tbpdKgg7t+xF6f0YIoqrW6YVQYraAVj AddamkDazUA0fOHDjgLSbk+eQpq+UYvY66JgwXqiZR0m3kmk2m5vgqoxbvv+IxLn1iWhcJ cbXx7dBBj3lBwWYMz+ou2ABtj1tdjTF8PfZaQKRoJfTGYkJoT9zd2WglH6LBnH8ApabhWF 0vDu91u9G2TCBWZouLdZfsWWGwj+1u132/2a2VaMLrpBPkZ0SNDrevf+rgw9rw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cWT7l5WxRzxPY; Tue, 23 Sep 2025 18:30:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58NIUxfd038592; Tue, 23 Sep 2025 18:30:59 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58NIUxc2038589; Tue, 23 Sep 2025 18:30:59 GMT (envelope-from git) Date: Tue, 23 Sep 2025 18:30:59 GMT Message-Id: <202509231830.58NIUxc2038589@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 43bbecaeb95f - main - tcp lro: remove redundant check List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 43bbecaeb95fe5ea1d7acffab4f2874247ba6915 Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=43bbecaeb95fe5ea1d7acffab4f2874247ba6915 commit 43bbecaeb95fe5ea1d7acffab4f2874247ba6915 Author: Michael Tuexen AuthorDate: 2025-09-23 18:28:54 +0000 Commit: Michael Tuexen CommitDate: 2025-09-23 18:28:54 +0000 tcp lro: remove redundant check Remove a check which is also done in tcp_lro_rx_common(). Reviewed by: gallatin MFC after: 3 days Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D52683 --- sys/netinet/tcp_lro.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/sys/netinet/tcp_lro.c b/sys/netinet/tcp_lro.c index 7512679bd4e9..64efa4bf060f 100644 --- a/sys/netinet/tcp_lro.c +++ b/sys/netinet/tcp_lro.c @@ -1428,17 +1428,6 @@ tcp_lro_rx(struct lro_ctrl *lc, struct mbuf *m, uint32_t csum) { int error; - if (((m->m_pkthdr.csum_flags & (CSUM_DATA_VALID | CSUM_PSEUDO_HDR)) != - ((CSUM_DATA_VALID | CSUM_PSEUDO_HDR))) || - (m->m_pkthdr.csum_data != 0xffff)) { - /* - * The checksum either did not have hardware offload - * or it was a bad checksum. We can't LRO such - * a packet. - */ - counter_u64_add(tcp_bad_csums, 1); - return (TCP_LRO_CANNOT); - } /* get current time */ binuptime(&lc->lro_last_queue_time); CURVNET_SET(lc->ifp->if_vnet);